Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mbedtls: change extension .so -> .dylib on Darwin #35209

Merged
merged 1 commit into from Feb 20, 2018
Merged

mbedtls: change extension .so -> .dylib on Darwin #35209

merged 1 commit into from Feb 20, 2018

Conversation

mnacamura
Copy link
Contributor

@mnacamura mnacamura commented Feb 20, 2018 •
edited

Motivation for this change

Some programs fail to find libraries with extension .so on Darwin. If the extension is .dylib, they can.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Feb 20, 2018

@GrahamcOfBorg build mbedtls
@GrahamcOfBorg build bctoolbox

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

these paths will be fetched (0.52 MiB download, 3.51 MiB unpacked):
  /nix/store/0slll8b22fiygp8v8vx79mzmb5ayndck-mbedtls-1.3.20
  /nix/store/ibdyl6c34d7z26bfl967shls3gsvd6a8-bcunit-3.0.2
  /nix/store/ybw2qyay364697ibq8qgz7sjbzz4in55-bctoolbox-0.6.0
copying path '/nix/store/ibdyl6c34d7z26bfl967shls3gsvd6a8-bcunit-3.0.2' from 'https://cache.nixos.org'...
copying path '/nix/store/0slll8b22fiygp8v8vx79mzmb5ayndck-mbedtls-1.3.20' from 'https://cache.nixos.org'...
copying path '/nix/store/ybw2qyay364697ibq8qgz7sjbzz4in55-bctoolbox-0.6.0' from 'https://cache.nixos.org'...
/nix/store/ybw2qyay364697ibq8qgz7sjbzz4in55-bctoolbox-0.6.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

these paths will be fetched (0.56 MiB download, 3.63 MiB unpacked):
  /nix/store/abhgcr9x4xvfz9nx44jagnk6nsjizmdm-bcunit-3.0.2
  /nix/store/c9pdxi7shqr93ll0v2jfxcgpsqypw6wk-bctoolbox-0.6.0
  /nix/store/riwx86z9pnn00zj9qyz1xihqc95zywad-mbedtls-1.3.20
copying path '/nix/store/abhgcr9x4xvfz9nx44jagnk6nsjizmdm-bcunit-3.0.2' from 'https://cache.nixos.org'...
copying path '/nix/store/riwx86z9pnn00zj9qyz1xihqc95zywad-mbedtls-1.3.20' from 'https://cache.nixos.org'...
copying path '/nix/store/c9pdxi7shqr93ll0v2jfxcgpsqypw6wk-bctoolbox-0.6.0' from 'https://cache.nixos.org'...
/nix/store/c9pdxi7shqr93ll0v2jfxcgpsqypw6wk-bctoolbox-0.6.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/88bg0di1k2h9gbr4zr3qfmbrk1jaclkw-mbedtls-2.6.1/bin/mbedtls_dtls_client
shrinking /nix/store/88bg0di1k2h9gbr4zr3qfmbrk1jaclkw-mbedtls-2.6.1/bin/mbedtls_gen_entropy
shrinking /nix/store/88bg0di1k2h9gbr4zr3qfmbrk1jaclkw-mbedtls-2.6.1/lib/libmbedcrypto.so.0
shrinking /nix/store/88bg0di1k2h9gbr4zr3qfmbrk1jaclkw-mbedtls-2.6.1/lib/libmbedx509.so.0
shrinking /nix/store/88bg0di1k2h9gbr4zr3qfmbrk1jaclkw-mbedtls-2.6.1/lib/libmbedtls.so.10
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/88bg0di1k2h9gbr4zr3qfmbrk1jaclkw-mbedtls-2.6.1/lib  /nix/store/88bg0di1k2h9gbr4zr3qfmbrk1jaclkw-mbedtls-2.6.1/bin 
patching script interpreter paths in /nix/store/88bg0di1k2h9gbr4zr3qfmbrk1jaclkw-mbedtls-2.6.1
checking for references to /tmp/nix-build-mbedtls-2.6.1.drv-0 in /nix/store/88bg0di1k2h9gbr4zr3qfmbrk1jaclkw-mbedtls-2.6.1...
/nix/store/88bg0di1k2h9gbr4zr3qfmbrk1jaclkw-mbedtls-2.6.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

test_suite_xtea ................................................... PASS
------------------------------------------------------------------------
PASSED (60 suites, 6109 tests run)
installing
install flags: install SHELL=/nix/store/19cc89zq5n68ibr53izy4zgcr5qg2rza-bash-4.4-p12/bin/bash SHARED=1 DLEXT=dylib DESTDIR=\$\{out\}
post-installation fixup
strip is /nix/store/v8ifq0hapblpr2z0hx4wvwg02w4aczqy-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/591w2cz2s6cabii39pm05h0405x1960s-mbedtls-2.6.1/lib  /nix/store/591w2cz2s6cabii39pm05h0405x1960s-mbedtls-2.6.1/bin
patching script interpreter paths in /nix/store/591w2cz2s6cabii39pm05h0405x1960s-mbedtls-2.6.1
/nix/store/591w2cz2s6cabii39pm05h0405x1960s-mbedtls-2.6.1

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘bctoolbox-0.6.0’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/libraries/bctoolbox/default.nix:16 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/ij15w0hyh71lzcnc8ff8bx0i6hm7zdqr-mbedtls-2.6.1/bin/mbedtls_crypt_and_hash
shrinking /nix/store/ij15w0hyh71lzcnc8ff8bx0i6hm7zdqr-mbedtls-2.6.1/bin/mbedtls_aescrypt2
shrinking /nix/store/ij15w0hyh71lzcnc8ff8bx0i6hm7zdqr-mbedtls-2.6.1/lib/libmbedcrypto.so.0
shrinking /nix/store/ij15w0hyh71lzcnc8ff8bx0i6hm7zdqr-mbedtls-2.6.1/lib/libmbedx509.so.0
shrinking /nix/store/ij15w0hyh71lzcnc8ff8bx0i6hm7zdqr-mbedtls-2.6.1/lib/libmbedtls.so.10
strip is /nix/store/skd6ix5ipkyhxzq7naylj4digawakl4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/ij15w0hyh71lzcnc8ff8bx0i6hm7zdqr-mbedtls-2.6.1/lib  /nix/store/ij15w0hyh71lzcnc8ff8bx0i6hm7zdqr-mbedtls-2.6.1/bin
patching script interpreter paths in /nix/store/ij15w0hyh71lzcnc8ff8bx0i6hm7zdqr-mbedtls-2.6.1
checking for references to /build in /nix/store/ij15w0hyh71lzcnc8ff8bx0i6hm7zdqr-mbedtls-2.6.1...
/nix/store/ij15w0hyh71lzcnc8ff8bx0i6hm7zdqr-mbedtls-2.6.1

@Mic92 Mic92 merged commit 4a26c9f into NixOS:master Feb 20, 2018
@mnacamura mnacamura deleted the mbedtls-darwin branch February 20, 2018 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mnacamura @Mic92 @GrahamcOfBorg