rabbitmq-server: 3.6.10 -> 3.6.15 (and various improvements) #35194

Profpatsch · 2018-02-19T18:35:58Z

split outputs (doc, man, out)
a new runtime dependency on getconf
fix up SCRIPTS_DIR in wrapper
clean output folder of stray doc files
add license & maintainer

Tested with nixos/tests/rabbitmq.nix, inside a docker image and manually.

cc @binarin @phunehehe @nlewo @datakurre

grahamc · 2018-02-19T18:57:22Z

@GrahamcOfBorg eval

An eval issue was introduced in to master, sorry for the false failure.

Profpatsch · 2018-02-19T20:50:46Z

@GrahamcOfBorg test rabbitmq
@GrahamcOfBorg eval

GrahamcOfBorg · 2018-02-19T20:55:52Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

cannot build derivation '/nix/store/xb0w0r541gp7d9njmarhlwr3jqyxjvdx-user-units.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/4xcr4yp65bhjvzrlyfk25pmw6bid86z9-system-units.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/vj7v9rmh482l1kii1cq2c0bad8l276i9-etc.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/zy3cbf7d6c0rk9y9dzqyjijqwkh4mffr-nixos-system-one--18.03.git.921aea8.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/lfx7a99wns2gjrfa3zmf54kr2qnp7c4r-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/zdkngdyspgks73q75ypk2vd0sa4kc0c0-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/2z07yjxdyqma1szia69x41v07pmf4ira-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/6jbyylz1lvk4c7447hcj1xl1zwaa8qz8-nixos-test-driver-rabbitmq.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/sd1zcb7y65wxd7l8nqfxsp5r9j5amhs8-vm-test-run-rabbitmq.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/sd1zcb7y65wxd7l8nqfxsp5r9j5amhs8-vm-test-run-rabbitmq.drv' failed

GrahamcOfBorg · 2018-02-19T20:59:24Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

cannot build derivation ‘/nix/store/d3h236aj5v5b6k6wxvm97qw8j6rylmn1-system-units.drv’: 3 dependencies couldn't be built
cannot build derivation ‘/nix/store/ccfvm30bgdc83ir52mzdrmsimr4i308d-user-units.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/9rid6lcz2iczg0n6lz9as3c0052ihg66-etc.drv’: 4 dependencies couldn't be built
cannot build derivation ‘/nix/store/pn96s0an8pf412d03n1x1a84y878fhk7-nixos-system-one--18.03.git.bafbac5.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/kgpjd1lp02m9fpnvbb0id6dxr7cd7b35-closure-info.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/y4br5bq31k6cwldilkx80hakghkh9prx-run-nixos-vm.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/q98jvyddc2ac9sfy5vypb0nki0brw98l-nixos-vm.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/2fkjv8s557a9p06kjbbxm4fyn3nh6ggc-nixos-test-driver-rabbitmq.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/6kac03c4jraxigb7v5lyczvjnpjrs99j-vm-test-run-rabbitmq.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/6kac03c4jraxigb7v5lyczvjnpjrs99j-vm-test-run-rabbitmq.drv’ failed

- split outputs (doc, man, out) - a new runtime dependency on getconf - fix up SCRIPTS_DIR in wrapper - clean output folder of stray doc files - add license & maintainer Tested with `nixos/tests/rabbitmq.nix`, inside a docker image and manually.

Profpatsch · 2018-02-19T21:14:05Z

@GrahamcOfBorg test rabbitmq

GrahamcOfBorg · 2018-02-19T21:19:03Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

cannot build derivation '/nix/store/xwnjpqdwxwzky0w9i840lp5sd4zffpn3-system-units.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/dzlwvkzq9kv11k79zwkfawxwn5q7w50i-user-units.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/gqq41jqi7wmy2sl1zh2n85kv33dyylbl-etc.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/043ghpsyp22qdl4l9ml2n2nfs05zbgqg-nixos-system-one--18.03.git.d9ffcee.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/7721m7vw5cwqj49bjw91gi7w55qkzkjk-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/gw4bps6f74dpqsrqb453hchrhqjpdvhl-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/ax6hji0gki0w7sbcq6s26836szx61f78-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/ha0f5qrw5p2grh4f81smpwvjgnnfycnw-nixos-test-driver-rabbitmq.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ck1nkchascpmcbn6ch1yjilz452b7wn2-vm-test-run-rabbitmq.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/ck1nkchascpmcbn6ch1yjilz452b7wn2-vm-test-run-rabbitmq.drv' failed

GrahamcOfBorg · 2018-02-19T21:22:40Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

cannot build derivation ‘/nix/store/lc55k2h2fknq229aa38qrdg4iz1y185g-system-units.drv’: 3 dependencies couldn't be built
cannot build derivation ‘/nix/store/b44zpmfmhx20b6yxc9rfwxyiagmjz0j5-user-units.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/r8x5hpbxn8y0bvisrlkswzcmn0b5d95y-etc.drv’: 4 dependencies couldn't be built
cannot build derivation ‘/nix/store/1nv2z628m51indnpbrlzllw3gr10pswk-nixos-system-one--18.03.git.1f5d266.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/2j82h6w3fk414rdfk3dlg1m70gvlfj42-closure-info.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/idh7sj5k2dx4idwx8x8dzn910d279jwr-run-nixos-vm.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/6k32nzn6h42899zsckmhrvfdnh9xl53l-nixos-vm.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/3kqm0gpbd2cvmh5b40jbwi4h2hvnk10i-nixos-test-driver-rabbitmq.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/zn467zwhcn57lk45fij1561b5a5rgnip-vm-test-run-rabbitmq.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/zn467zwhcn57lk45fij1561b5a5rgnip-vm-test-run-rabbitmq.drv’ failed

Profpatsch · 2018-02-20T11:19:51Z

Hm, nix seems to be broken on master?

@GrahamcOfBorg test rabbitmq

GrahamcOfBorg · 2018-02-20T11:30:00Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

cannot build derivation '/nix/store/vxvj43k634kj9kzh96hb8xv53lgfl21p-user-units.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/4z103vvpjhlx4g6l5ym0csn0dmafd4qi-system-units.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/zgw861spmi6g4w77zrszsh73lbm3gwm9-etc.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/yk826rynak2ipmc8472659bdn164ihli-nixos-system-one--18.03.git.b0dcf3f.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/ax2sjncx37qdd53b1d66qwqnzhbi631n-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/nhzxl1wyr7r5cywgjz5b0kck48rnx9vm-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/h9r531sgyxvhjl7hnhqay6jiw3kk99r5-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/5a1aazp6j0wrki2hili1jvr10jdbk0hv-nixos-test-driver-rabbitmq.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/pi557gs0v9gganifdkrkn2lzzpnf3yy3-vm-test-run-rabbitmq.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/pi557gs0v9gganifdkrkn2lzzpnf3yy3-vm-test-run-rabbitmq.drv' failed

GrahamcOfBorg · 2018-02-20T11:40:02Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

one: running command: systemctl --no-pager show "rabbitmq.service"
one: exit status 0
error: unit ‘rabbitmq.service’ reached state ‘failed’
unit ‘rabbitmq.service’ reached state ‘failed’
cleaning up
killing one (pid 596)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-rabbitmq.drv-0/vde1.ctl': Directory not empty
builder for ‘/nix/store/b04rhr8j68y1vpmzikdg5a1d2ymqmyp5-vm-test-run-rabbitmq.drv’ failed with exit code 255
error: build of ‘/nix/store/b04rhr8j68y1vpmzikdg5a1d2ymqmyp5-vm-test-run-rabbitmq.drv’ failed

Profpatsch · 2018-02-20T11:53:35Z

@GrahamcOfBorg eval
okay, I’m lost.

Profpatsch · 2018-02-22T12:34:14Z

@GrahamcOfBorg test rabbitmq
@GrahamcOfBorg eval

GrahamcOfBorg · 2018-02-22T12:36:43Z

Success on x86_64-linux (full log)

Partial log (click to expand)

one: exit status 1
syncing
one: running command: sync
one: exit status 0
test script finished in 21.58s
cleaning up
killing one (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-rabbitmq.drv-0/vde1.ctl': Directory not empty
/nix/store/qyf1kzbn7lm608ps8wanzlarncmbacdp-vm-test-run-rabbitmq

GrahamcOfBorg · 2018-02-22T12:37:21Z

Success on x86_64-linux (full log)

Partial log (click to expand)

one: exit status 1
syncing
one: running command: sync
one: exit status 0
test script finished in 21.03s
cleaning up
killing one (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-rabbitmq.drv-0/vde1.ctl': Directory not empty
/nix/store/r3bvyz5sr195a4j4yj7gzz4ygwrpfl2l-vm-test-run-rabbitmq

daniel-barlow · 2018-04-09T16:05:00Z

I don't know enough about RabbitMQ or about Darwin to identify root cause, but this package is broken on my MacOS High Sierra machine right now and I think the getconf changes here are involved

building '/nix/store/xn32vzxwi2zjk3831ngyr4ih7blmdqr7-getconf.drv'...
install: cannot stat '/nix/store/qhs4rapnq2nx43clsnls3ybllag0qyhc-Libsystem-osx-10.11.6/bin/getconf': No such file or directory
builder for '/nix/store/xn32vzxwi2zjk3831ngyr4ih7blmdqr7-getconf.drv' failed with exit code 1
cannot build derivation '/nix/store/v719hgkv7q4b25an086f5x12wg3bzn7w-rabbitmq-server-3.6.15.drv': 1 dependencies couldn't be built

Is ${stdenv.lib.getBin stdenv.cc.libc}/bin/getconf supposed to exist everywhere or is it a glibc thing?

Profpatsch · 2018-04-09T16:36:04Z

Is ${stdenv.lib.getBin stdenv.cc.libc}/bin/getconf supposed to exist everywhere or is it a glibc thing?

That could be the case. @Ericson2314 or @LnL7 might know more.

Profpatsch · 2018-04-09T16:37:17Z

pkgs/servers/amqp/rabbitmq-server/default.nix

+  # we only need that one glibc binary (28k instead of 2.7M)
+  getconf = runCommand "getconf" {} ''
+    install -D ${stdenv.lib.getBin stdenv.cc.libc}/bin/getconf $out/bin/getconf
+  '';


This is the change that might have broken MacOS.

Ericson2314 · 2018-04-09T18:30:25Z

Is ${stdenv.lib.getBin stdenv.cc.libc}/bin/getconf supposed to exist everywhere or is it a glibc thing?

@matthewbauer @dtzWill would know the answer better than I. See #37056 for analogous concerns regarding libraries.

dtzWill · 2018-04-10T23:22:10Z

Can't say re:darwin. There's a top-level attribute for the package providing getconf so I suggest using that. If getconf is not available on Darwin (perhaps doesn't make sense), it probably makes sense to provide whatever behavior was used here on Darwin previously or mark the package broken if it turns out rabbitmq-server has a hard dependency on a utility that isn't available.

matthewbauer · 2018-04-10T23:28:40Z

getconf is part of POSIX so it should work on Darwin. It's not packaged yet but we should be able to get it working in Darwin. Right now you should just rely on top-level "getconf" attribute though.

http://pubs.opengroup.org/onlinepubs/9699919799//utilities/getconf.html

matthewbauer · 2018-04-11T04:15:43Z

I think I have this fixed in 037e5d8

Profpatsch · 2018-04-11T15:49:50Z

I think I have this fixed in 037e5d8

That is, in fact, not a correct fix. The getconf attribute defaults to the glibc closure. Would be nicer to do such things through PRs instead of pushing directly. I suggest we revert that and add a better solution (that is one that extracts the getconf binary into its own derivation like my PR here did).

Edit: Okay, I’m confused; it is a pull request?

Ericson2314 · 2018-04-11T18:41:04Z

@Profpatsch it was part of a PR that was merged. the "unix-tools" infra pulls out just the single needed binary as you intend.

Profpatsch mentioned this pull request Feb 19, 2018

Modern RabbitMQ #34265

Merged

8 tasks

Profpatsch force-pushed the rabbitmq-3.6.15-fixes branch from 4ca6cb9 to d36ff04 Compare February 19, 2018 19:20

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 19, 2018

NixOS deleted a comment from GrahamcOfBorg Feb 19, 2018

Profpatsch force-pushed the rabbitmq-3.6.15-fixes branch from d36ff04 to 32d6f2f Compare February 19, 2018 20:50

Profpatsch mentioned this pull request Feb 19, 2018

Distinguish tests from evals and other checks more closely NixOS/ofborg#80

Closed

Profpatsch force-pushed the rabbitmq-3.6.15-fixes branch from 32d6f2f to e118485 Compare February 19, 2018 21:11

GrahamcOfBorg added the 6.topic: nixos label Feb 19, 2018

NixOS deleted a comment from GrahamcOfBorg Feb 22, 2018

Profpatsch merged commit 186c765 into NixOS:master Feb 22, 2018

Profpatsch commented Apr 9, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rabbitmq-server: 3.6.10 -> 3.6.15 (and various improvements) #35194

rabbitmq-server: 3.6.10 -> 3.6.15 (and various improvements) #35194

Profpatsch commented Feb 19, 2018

grahamc commented Feb 19, 2018

Profpatsch commented Feb 19, 2018

GrahamcOfBorg commented Feb 19, 2018

GrahamcOfBorg commented Feb 19, 2018

Profpatsch commented Feb 19, 2018

GrahamcOfBorg commented Feb 19, 2018

GrahamcOfBorg commented Feb 19, 2018

Profpatsch commented Feb 20, 2018

GrahamcOfBorg commented Feb 20, 2018

GrahamcOfBorg commented Feb 20, 2018

Profpatsch commented Feb 20, 2018

Profpatsch commented Feb 22, 2018 •

edited

GrahamcOfBorg commented Feb 22, 2018

GrahamcOfBorg commented Feb 22, 2018

daniel-barlow commented Apr 9, 2018

Profpatsch commented Apr 9, 2018 •

edited

Profpatsch Apr 9, 2018

Ericson2314 commented Apr 9, 2018 •

edited

dtzWill commented Apr 10, 2018

matthewbauer commented Apr 10, 2018

matthewbauer commented Apr 11, 2018

Profpatsch commented Apr 11, 2018 •

edited

Ericson2314 commented Apr 11, 2018

rabbitmq-server: 3.6.10 -> 3.6.15 (and various improvements) #35194

rabbitmq-server: 3.6.10 -> 3.6.15 (and various improvements) #35194

Conversation

Profpatsch commented Feb 19, 2018

grahamc commented Feb 19, 2018

Profpatsch commented Feb 19, 2018

GrahamcOfBorg commented Feb 19, 2018

GrahamcOfBorg commented Feb 19, 2018

Profpatsch commented Feb 19, 2018

GrahamcOfBorg commented Feb 19, 2018

GrahamcOfBorg commented Feb 19, 2018

Profpatsch commented Feb 20, 2018

GrahamcOfBorg commented Feb 20, 2018

GrahamcOfBorg commented Feb 20, 2018

Profpatsch commented Feb 20, 2018

Profpatsch commented Feb 22, 2018 • edited

GrahamcOfBorg commented Feb 22, 2018

GrahamcOfBorg commented Feb 22, 2018

daniel-barlow commented Apr 9, 2018

Profpatsch commented Apr 9, 2018 • edited

Profpatsch Apr 9, 2018

Choose a reason for hiding this comment

Ericson2314 commented Apr 9, 2018 • edited

dtzWill commented Apr 10, 2018

matthewbauer commented Apr 10, 2018

matthewbauer commented Apr 11, 2018

Profpatsch commented Apr 11, 2018 • edited

Ericson2314 commented Apr 11, 2018

Profpatsch commented Feb 22, 2018 •

edited

Profpatsch commented Apr 9, 2018 •

edited

Ericson2314 commented Apr 9, 2018 •

edited

Profpatsch commented Apr 11, 2018 •

edited