Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixUnstable: bump for minor fix to unbreak seccomp builds #35193

Merged
merged 1 commit into from Feb 19, 2018
Merged

nixUnstable: bump for minor fix to unbreak seccomp builds #35193

merged 1 commit into from Feb 19, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 19, 2018

cc @shlevy

Although let's let borg confirm this fixes things :)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

@GrahamcOfBorg eval

@grahamc
Copy link
Member

grahamc commented Feb 19, 2018

@GrahamcOfBorg eval

An eval issue was introduced in to master, sorry for the false failure.

@shlevy
Copy link
Member

shlevy commented Feb 19, 2018

@GrahamcOfBorg build nixUnstable

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

    chmod: changing permissions of '/private/tmp/nix-test/store/vsp6si7iihwzd3imh656a8w0dbg5zl9z-nondeterministic.drv': Operation not permitted
running test tests/plugins.sh... [FAIL]
    + set -o pipefail
    ++ nix eval '(builtins.anotherNull)' --option setting-set true --option plugin-files /private/tmp/nix-build-nix-2.0pre5968_a6c0b773.drv-0/source/tests/plugins/libplugintest.dylib
    error: opening lock file '/private/tmp/nix-test/var/nix/db/big-lock': Permission denied
    + res=
47 out of 50 tests failed
make: *** [mk/tests.mk:12: installcheck] Error 1
builder for '/nix/store/k14hxlzbf7q869wzx5axpgv6byn60fsp-nix-2.0pre5968_a6c0b773.drv' failed with exit code 2
error: build of '/nix/store/k14hxlzbf7q869wzx5axpgv6byn60fsp-nix-2.0pre5968_a6c0b773.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

running test tests/fetchGit.sh... [SKIP]
running test tests/fetchMercurial.sh... [SKIP]
running test tests/signing.sh... [PASS]
running test tests/run.sh... [PASS]
running test tests/brotli.sh... [PASS]
running test tests/pure-eval.sh... [PASS]
running test tests/check.sh... [PASS]
running test tests/plugins.sh... [PASS]
All tests succeeded
/nix/store/n1813017i47fv4yg4dqjl56f79wm36c7-nix-2.0pre5968_a6c0b773

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

    chmod: changing permissions of '/private/tmp/nix-test/store/vsp6si7iihwzd3imh656a8w0dbg5zl9z-nondeterministic.drv': Operation not permitted
running test tests/plugins.sh... [FAIL]
    + set -o pipefail
    ++ nix eval '(builtins.anotherNull)' --option setting-set true --option plugin-files /private/tmp/nix-build-nix-2.0pre5968_a6c0b773.drv-0/source/tests/plugins/libplugintest.dylib
    error: opening lock file '/private/tmp/nix-test/var/nix/db/big-lock': Permission denied
    + res=
47 out of 50 tests failed
make: *** [mk/tests.mk:12: installcheck] Error 1
builder for '/nix/store/k14hxlzbf7q869wzx5axpgv6byn60fsp-nix-2.0pre5968_a6c0b773.drv' failed with exit code 2
error: build of '/nix/store/k14hxlzbf7q869wzx5axpgv6byn60fsp-nix-2.0pre5968_a6c0b773.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

running test tests/fetchGit.sh... [SKIP]
running test tests/fetchMercurial.sh... [SKIP]
running test tests/signing.sh... [PASS]
running test tests/run.sh... [PASS]
running test tests/brotli.sh... [PASS]
running test tests/pure-eval.sh... [PASS]
running test tests/check.sh... [PASS]
running test tests/plugins.sh... [PASS]
All tests succeeded
/nix/store/xp8cy89d1r2zfi08m32crky59lzn7i4i-nix-2.0pre5968_a6c0b773

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

these derivations will be built:
  /nix/store/1vbw00l1vx8q56dprp9gmi1r1cs4vwgk-nix-2.0pre5968_a6c0b773.drv
waiting for locks or build slots...
/nix/store/xp8cy89d1r2zfi08m32crky59lzn7i4i-nix-2.0pre5968_a6c0b773

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

running test tests/fetchGit.sh... [SKIP]
running test tests/fetchMercurial.sh... [SKIP]
running test tests/signing.sh... [PASS]
running test tests/run.sh... [PASS]
running test tests/brotli.sh... [PASS]
running test tests/pure-eval.sh... [PASS]
running test tests/check.sh... [PASS]
running test tests/plugins.sh... [PASS]
All tests succeeded
/nix/store/n1813017i47fv4yg4dqjl56f79wm36c7-nix-2.0pre5968_a6c0b773

@shlevy
Copy link
Member

shlevy commented Feb 19, 2018

@grahamc Any idea what's going on with that darwin failure?

@grahamc
Copy link
Member

grahamc commented Feb 19, 2018

@GrahamcOfBorg build nixUnstable

A previous build of nixUnstable on the mac failed to clean up after itself in TMP :(

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/xp8cy89d1r2zfi08m32crky59lzn7i4i-nix-2.0pre5968_a6c0b773

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/n1813017i47fv4yg4dqjl56f79wm36c7-nix-2.0pre5968_a6c0b773

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

    chmod: changing permissions of '/private/tmp/nix-test/store/vsp6si7iihwzd3imh656a8w0dbg5zl9z-nondeterministic.drv': Operation not permitted
running test tests/plugins.sh... [FAIL]
    + set -o pipefail
    ++ nix eval '(builtins.anotherNull)' --option setting-set true --option plugin-files /private/tmp/nix-build-nix-2.0pre5968_a6c0b773.drv-0/source/tests/plugins/libplugintest.dylib
    error: opening lock file '/private/tmp/nix-test/var/nix/db/big-lock': Permission denied
    + res=
47 out of 50 tests failed
make: *** [mk/tests.mk:12: installcheck] Error 1
builder for '/nix/store/k14hxlzbf7q869wzx5axpgv6byn60fsp-nix-2.0pre5968_a6c0b773.drv' failed with exit code 2
error: build of '/nix/store/k14hxlzbf7q869wzx5axpgv6byn60fsp-nix-2.0pre5968_a6c0b773.drv' failed

@shlevy
Copy link
Member

shlevy commented Feb 19, 2018

@grahamc Still?

@shlevy
Copy link
Member

shlevy commented Feb 19, 2018

Going to merge this, as the build has finished on hydra

@dtzWill
Copy link
Member Author

dtzWill commented Feb 19, 2018

Hydra built a few revisions past AFAICT, but either way. Since this unbreaks linux it's probably the best option to merge.

@dtzWill
Copy link
Member Author

dtzWill commented Feb 19, 2018

merged in 3826ab2

@dtzWill dtzWill closed this Feb 19, 2018
@shlevy shlevy merged commit cbae401 into NixOS:master Feb 19, 2018
@grahamc
Copy link
Member

grahamc commented Feb 20, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @joachifm @grahamc @shlevy @GrahamcOfBorg