[ruby-2.5] Implement String#delete_suffix #5055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also refactored the delete_prefix functions.
c&p from 510957df33be322875e7d863b9af6934f2574779
ChrisBr
force-pushed
the
ruby25/delete_suffix
branch
from
cfd758b
to
21be6f2
Compare
|
I assume the tests just come from MRI? I can update the tests on ruby-2.5 to match Ruby 2.5.0's tests...I had not up to this point because it will mean hundreds of errors for things we haven't implemented yet, but I suppose that's a good way to know what's left too :-) There's no harm in pulling in this test now if it's just from MRI, since we'll run their tests soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See feature https://bugs.ruby-lang.org/issues/13665 and ruby/ruby@510957d