Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: updates and fixes #35198

Merged
merged 26 commits into from Feb 22, 2018
Merged

python: updates and fixes #35198

merged 26 commits into from Feb 22, 2018

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Feb 19, 2018 •
edited

Motivation for this change

Fix some broken Python packages from https://hydra.nixos.org/eval/1434362#tabs-still-fail

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

/cc bibtexparser maintainer @FRidh
/cc curtsies maintainer @flokli
/cc dbf maintainer @vrthra
/cc prov maintainer @ashgillman

@ashgillman
Copy link
Contributor

Thanks. Prov changes look good to me.

Looking through that list, a number of packages I work with have failed due to scipy taking too long.

@dotlambda
Copy link
Member Author

One of the commtis actually replaces python-termstyle by termstyle, which is a good thing in my opinion.
However, I still have to fix green, which depends on python-termstyle.

@FRidh FRidh self-assigned this Feb 20, 2018
@FRidh
Copy link
Member

FRidh commented Feb 20, 2018

Hydra job at https://hydra.nixos.org/eval/1434873 for ae66b64

@dotlambda
Copy link
Member Author

Didn't you fix natsort somewhere?

This was referenced Feb 20, 2018
Closed
Closed
@dotlambda
Copy link
Member Author

dotlambda commented Feb 20, 2018 •
edited

I think I'm done here for now. Can you start another Hydra job?

@dotlambda
Copy link
Member Author

@rybern I had to mark pomegranate as broken. See jmschrei/pomegranate#209.

@FRidh
Copy link
Member

FRidh commented Feb 21, 2018 •
edited

Another job at https://hydra.nixos.org/eval/1435157. Note that I rebased on staging.

@dotlambda
Copy link
Member Author

@rycee Just a ping because I fixed pytrainer.

@FRidh Most of the new failures are due to #35301. I think we should merge this one and I'll open a new PR as soon as I have accumulated some fixes again.

Robert Schütz added 16 commits February 22, 2018 01:46
pythonPackages.prov: fix build and enable tests
8f93cba 
Tests do not actually take 60 minutes.
pythonPackages.xdot: move expression
fac32de
pythonPackages.green: 2.3.0 -> 2.12.0
2bdee9b
pythonPackages.asgiref: correct dependencies and enable tests
b49db62
pythonPackages.asgiref: 2.1.5 -> 2.1.6
8747ebd
pythonPackages.daphne: fix build and enable tests
40b0c58
pythonPackages.pytest_xdist: 1.22.0 -> 1.22.1
958bd34
pythonPackages.natsort: fix tests
d3a3475 
A coverage report is definitely not needed for Nixpkgs.
pythonPackages.text-unidecode: init at 1.1
35ee24f
pythonPackages.faker: 0.8.8 -> 0.8.11
495bb79 
This fixes the build failure by adding a missing dependency and because 0.8.11 allows a newer version of ukpostcodeparser.
pythonPackages.cram: fix tests
e426e3f
pythonPackages.pytest-mock: fix build
1977a2d 
This applies the following patch: pytest-dev/pytest-mock#107
pythonPackages.promegranate: mark as broken
882cf12 
"pomegranate does not yet work with networkx 2.0"
pytrainer: fix tests
da31b47
pythonPackages.konfig: move expression
c7a6483
pythonPackages.konfig: fix tests
0862ca3
@dotlambda
Copy link
Member Author

@garbas @domenkozar Is it okay that I removed mysql_connector_repackaged? It is currently broken and grepping through Nixpkgs didn't yield any dependents. You can use mysql-connector instead.

Robert Schütz added 2 commits February 22, 2018 01:51
pythonPackages.ecpy: disable for python 2
9b37f0a 
setup.py specifies
    python_requires='>=3'
pythonPackages.mysql_connector_repackaged: uninit
198bdf3 
Package has last been updated in 2012.
There is now also pythonPackages.mysql-connector.
@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

cannot build derivation ‘/nix/store/3gwyapiz7s2j8f3d0x51kfypabcl34pl-gpsbabel-1.5.4.drv’: 4 dependencies couldn't be built
cannot build derivation ‘/nix/store/wacsmfj8xhc3ic3axvma0b6421v1d4fq-gtk+-2.24.32.drv’: 18 dependencies couldn't be built
cannot build derivation ‘/nix/store/pb1hbr7ivlgjwqk0cphviqszphr905fa-python2.7-urllib3-1.22.drv’: 13 dependencies couldn't be built
cannot build derivation ‘/nix/store/x5p6hwb3dkk4x0gkfw1dm211lw620d2p-libglade-2.6.4.drv’: 7 dependencies couldn't be built
cannot build derivation ‘/nix/store/yqk3fnbgq6zgn1ww5155b9jr5hq38pb6-python2.7-requests-2.18.4.drv’: 12 dependencies couldn't be built
cannot build derivation ‘/nix/store/db8ijlh8ymnmg7b9mnbmx990amikrch3-python2.7-Sphinx-1.7.0.drv’: 25 dependencies couldn't be built
cannot build derivation ‘/nix/store/3aa05csxd3w9sksjdl168qj53kbcangn-python2.7-pygtk-2.24.0.drv’: 12 dependencies couldn't be built
cannot build derivation ‘/nix/store/jqd6q9s9n0g6z7dmg4xbgjwran3r0j3g-python2.7-matplotlib-2.1.2.drv’: 25 dependencies couldn't be built
cannot build derivation ‘/nix/store/anm0yfdx10bvyr1q6qb7m25s9smb8x5r-pytrainer-1.11.0.drv’: 15 dependencies couldn't be built
error: build of ‘/nix/store/anm0yfdx10bvyr1q6qb7m25s9smb8x5r-pytrainer-1.11.0.drv’ failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/595nmgjslsfybavzgfisvfn21h0sqda9-gpsbabel-1.5.4
shrinking /nix/store/595nmgjslsfybavzgfisvfn21h0sqda9-gpsbabel-1.5.4/bin/gpsbabel
strip is /nix/store/ggjc1mfsicyq31xlg5d51hl9lc21wxnv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/595nmgjslsfybavzgfisvfn21h0sqda9-gpsbabel-1.5.4/bin
patching script interpreter paths in /nix/store/595nmgjslsfybavzgfisvfn21h0sqda9-gpsbabel-1.5.4
checking for references to /build in /nix/store/595nmgjslsfybavzgfisvfn21h0sqda9-gpsbabel-1.5.4...
postPatchMkspecs
cannot build derivation '/nix/store/gncihgp3azv66gy3gjg5hsv4z7m551kj-pytrainer-1.11.0.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/gncihgp3azv66gy3gjg5hsv4z7m551kj-pytrainer-1.11.0.drv' failed

@garbas
Copy link
Member

garbas commented Feb 22, 2018

@dotlambda ok by me.

@FRidh FRidh merged commit 743a33a into NixOS:staging Feb 22, 2018
@dotlambda dotlambda deleted the python branch February 22, 2018 09:19
@dotlambda dotlambda mentioned this pull request Feb 23, 2018
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@FRidh FRidh

Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dotlambda @ashgillman @FRidh @GrahamcOfBorg @garbas