Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a reasonable self.logger to all plugins #2977

Merged
merged 5 commits into from Mar 13, 2018
Merged

Add a reasonable self.logger to all plugins #2977

merged 5 commits into from Mar 13, 2018

Conversation

ralsina
Copy link
Member

@ralsina ralsina commented Mar 8, 2018

We were using self.logger in some plugins and it was never actually initialized.

This fixes that and removes some code it makes redundant in the rest compiler.

@Kwpolska
Copy link
Member

Kwpolska commented Mar 8, 2018

In which plugins? Are there no plugins that would create a logger twice now?

@ralsina
Copy link
Member Author

ralsina commented Mar 8, 2018

@Kwpolska the ones I see are:

  • pandoc
  • html
  • markdown

These were now doing this twice (removed it from the plugin):

  • ipynb
  • bundles
  • galleries
  • scale_images
  • deploy
  • serve
  • check

Pushing now fixes for all of them.

@ralsina ralsina merged commit 5a2d2f4 into master Mar 13, 2018
@ralsina ralsina deleted the more-compilers-with-newer-shortcodes branch March 17, 2018 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ralsina @Kwpolska