Add sundials #36526
Add sundials #36526
Conversation
|
Please change the commit message to |
| }; | ||
|
|
||
| preConfigure = '' | ||
| export cmakeFlags="-DCMAKE_INSTALL_PREFIX=$out -DEXAMPLES_INSTALL_PATH=$out/share/examples $cmakeFlags" |
There was a problem hiding this comment.
You can say cmakeFlags = ... as a top-level attribute rather than setting it in preConfigure I believe.
There was a problem hiding this comment.
Yes, that should be possible. See here for an example.
|
The example also has |
|
Hah, should've looked further. You could try this out. Maybe it works now. |
GrahamcOfBorg
added
6.topic: emacs
6.topic: GNOME
GrahamcOfBorg
removed
6.topic: emacs
6.topic: GNOME
GrahamcOfBorg
removed
6.topic: haskell
6.topic: nixos
6.topic: printing
6.topic: python
6.topic: qt/kde
6.topic: rust
6.topic: steam
6.topic: vim
6.topic: xfce
|
It seems I am not a maintainer? |
| description = "Suite of nonlinear differential/algebraic equation solvers"; | ||
| homepage = https://computation.llnl.gov/casc/sundials/main.html; | ||
| platforms = platforms.all; | ||
| maintainers = [ idontgetoutmuch ]; |
There was a problem hiding this comment.
You need to add an appropriate attribute in maintainers/maintainer-list.nix and refer to that in the maintainers field.
There was a problem hiding this comment.
Please note that you must refer to maintainers.idontgetoutmuch here.
| homepage = https://computation.llnl.gov/casc/sundials/main.html; | ||
| platforms = platforms.all; | ||
| maintainers = [ idontgetoutmuch ]; | ||
| licencse = { url = https://computation.llnl.gov/projects/sundials/license; }; |
There was a problem hiding this comment.
Typo here: licencse -> license. Also that looks like a three-clause BSD license and thus can be referenced by licenses.bsd3.
|
@peti what else do I need to do? |
Motivation for this change
A good package for solving differential equations that ought to be in nix.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)