Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-cli: 0.10.17 -> 2.0.27 #36528

Closed
wants to merge 8 commits into from
Closed

azure-cli: 0.10.17 -> 2.0.27 #36528

wants to merge 8 commits into from

Conversation

lamdor
Copy link
Contributor

@lamdor lamdor commented Mar 8, 2018

Motivation for this change

The azure-cli that was here before was very outdated. It's now written in python3 and has a mess of new python packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Necessary for azure-cli python packages
Necessary for azure-cli python packages
Necessary for azure-cli python packages
Necessary for azure-cli python packages
Necessary for azure-cli python packages
Necessary for azure-cli python packages
@FRidh
Copy link
Member

FRidh commented May 13, 2018

Thanks for the PR. This is a huge change, and would be very hard to maintain I'm afraid. How do you plan to maintain this?

@colemickens
Copy link
Member

I'm also curious how you made this change. I've not been able to get pypi2nix to work with it, and I'm interested in having this available and possibly maintaining.

@lamdor
Copy link
Contributor Author

lamdor commented Jun 13, 2018

Yeah, I agree that this will be painful to maintain. The way I created them was a lot of checking pypi.org for packages and figuring out the dependencies from there. It took a few hours. I would've liked to have to tried pypi2nix, but I also couldn't get it to work, but I'm a python noob.

I'll come back to this and see figure out some path forward.

@colemickens
Copy link
Member

cc: @garbas for any input/suggestions, also ref: nix-community/pypi2nix#194

@Mic92 Mic92 mentioned this pull request Dec 7, 2018
10 tasks
@flokli
Copy link
Contributor

flokli commented Mar 30, 2019

Has the situation gotten any better? azure-cli is at 2.0.61 by now…

@matthiasbeyer
Copy link
Contributor

This is stalled and should probably be closed. @FRidh

@jonringer
Copy link
Contributor

jonringer commented Aug 8, 2019

the azure-{,mgmt}-* packages have been added by #60435 (rotting a huge portion of this PR)

recently, the azure-cli consolidated/flattened a lot of their azure-cli-* namespace packages into the azure-cli package Azure/azure-cli#9590

Also, the azure-cli is meant to be a "flexible" interactive tool, in which the surface API isn't stable at all. See https://docs.microsoft.com/en-us/cli/azure/release-notes-azure-cli?view=azure-cli-latest for "removed" or "BREAKING CHANGE" entries. (So this would be very hard to maintain, as the dependency graph is also very dynamic between, or overly constrained on certain packages see setup.py

At the very least, I would recommend closing this ticket @FRidh

@flokli
Copy link
Contributor

flokli commented Aug 9, 2019

Let's close this, we can always resume from what's in this PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants