Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collectd: kafka patch for 18.03 #36257

Merged
merged 2 commits into from Mar 3, 2018
Merged

collectd: kafka patch for 18.03 #36257

merged 2 commits into from Mar 3, 2018

Conversation

lukeadams
Copy link
Contributor

@lukeadams lukeadams commented Mar 3, 2018 •
edited

Motivation for this change

Fixes collectd on 18.03 by adding upstream patch.

Currently broken on hydra.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Mar 3, 2018

@GrahamcOfBorg build collectd

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘oraclejdk-8u161’ in /var/lib/gc-of-borg/nix-test-rs-18/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-18/pkgs/development/compilers/oraclejdk/jdk-linux-base.nix:71 has an unfree license (‘unfree’), refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘riemann-c-client-1.9.1’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/tools/misc/riemann-c-client/default.nix:20 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/y3a8s54zgjkr3s3c4ixfm30gbb6ncavv-collectd-5.8.0/lib/collectd/table.so
shrinking /nix/store/y3a8s54zgjkr3s3c4ixfm30gbb6ncavv-collectd-5.8.0/lib/collectd/curl_json.so
shrinking /nix/store/y3a8s54zgjkr3s3c4ixfm30gbb6ncavv-collectd-5.8.0/lib/collectd/lvm.so
gzipping man pages under /nix/store/y3a8s54zgjkr3s3c4ixfm30gbb6ncavv-collectd-5.8.0/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/y3a8s54zgjkr3s3c4ixfm30gbb6ncavv-collectd-5.8.0/lib  /nix/store/y3a8s54zgjkr3s3c4ixfm30gbb6ncavv-collectd-5.8.0/bin  /nix/store/y3a8s54zgjkr3s3c4ixfm30gbb6ncavv-collectd-5.8.0/sbin 
patching script interpreter paths in /nix/store/y3a8s54zgjkr3s3c4ixfm30gbb6ncavv-collectd-5.8.0
checking for references to /tmp/nix-build-collectd-5.8.0.drv-0 in /nix/store/y3a8s54zgjkr3s3c4ixfm30gbb6ncavv-collectd-5.8.0...
moving /nix/store/y3a8s54zgjkr3s3c4ixfm30gbb6ncavv-collectd-5.8.0/sbin/* to /nix/store/y3a8s54zgjkr3s3c4ixfm30gbb6ncavv-collectd-5.8.0/bin
/nix/store/y3a8s54zgjkr3s3c4ixfm30gbb6ncavv-collectd-5.8.0

@Mic92 Mic92 merged commit 6e316ed into NixOS:master Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukeadams @Mic92 @GrahamcOfBorg