Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WASD keys in 2048.cr #5764

Closed
wants to merge 1 commit into from
Closed

Add WASD keys in 2048.cr #5764

wants to merge 1 commit into from

Conversation

wooster0
Copy link
Contributor

@wooster0 wooster0 commented Mar 3, 2018

So you can use WASD keys also if capital letters are enabled.

So you can use WASD also if capital letters are enabled.
@bew
Copy link
Contributor

bew commented Mar 3, 2018

Looks like there is already wasd, why add WASD ?

@wooster0
Copy link
Contributor Author

wooster0 commented Mar 3, 2018

With this you can also use the wasd keys even if you have enabled caps lock. Maybe you have still enabled caps lock for some reason and then you want to use wasd keys to control. But then it doesn't works because it only accepts downcase wasd. So I added this.

And at the q key there is already support for the uppercase q. So why not at wasd too?

@bew
Copy link
Contributor

bew commented Mar 3, 2018

What if the user's keyboard is not qwerty (like me)? Should we handle all existing keyboard layout and combinations of caps locks, etc?

@wooster0
Copy link
Contributor Author

wooster0 commented Mar 3, 2018

But whats with the Q key? Why is this supported then?

@bew
Copy link
Contributor

bew commented Mar 3, 2018

I don't know, maybe the one who did this sample code has an habit for quitting a software with Q. I don't think that's because of caps lock.

@wooster0
Copy link
Contributor Author

wooster0 commented Mar 3, 2018

Hm okay :/

@wooster0 wooster0 closed this Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants