Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installables: Support unprefixed NIX_PATH lookups. #1942

Closed
wants to merge 1 commit into from

Conversation

shlevy
Copy link
Member

@shlevy shlevy commented Mar 3, 2018

Fixes #1865

@shlevy
Copy link
Member Author

shlevy commented Mar 7, 2018

@edolstra Is this OK?

@edolstra
Copy link
Member

edolstra commented Mar 7, 2018

No, because adding every file in every directory listed in NIX_PATH sounds like it could seriously pollute the set of expressions evaluated by nix, potentially adding expressions that are not intended to be package sources.

For example, with the NIX_PATH on NixOS, this adds every package in Nixpkgs as a nixos.* set, doubling evaluation time for nix search and creating ambiguity. It also adds files like nixos-config which is also not exactly elegant.

In short NIX_PATH is not intended for this. The current use of nixpkgs= is a placeholder to be replaced when we have a proper nix-channel replacement.

@shlevy shlevy closed this Mar 7, 2018
@shlevy shlevy deleted the installables-unnamed-nix-path branch March 7, 2018 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants