Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: cf1b51aba278
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 24684008df7b
Choose a head ref
  • 5 commits
  • 4 files changed
  • 1 contributor

Commits on Mar 4, 2018

  1. Convert maintainer file entries to attributes, add github handles 

    Based on #34842, the
nix-instantiate output was pretty-printed and the validity of the github handles
manually verified, by automatically checking whether the user handles exist on
github (https://github.com/userhandle, status 200 or 404).
Each handle under 5 characters was manually checked (because the collision
probability with non-maintainer accounts is high), each missing entry was
manually researched.

The script used is kept in `maintainers/scripts` as an example of how to work
with the mainainers list through nix’ JSON interface.
    @Profpatsch
    Profpatsch committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    aa47bac View commit details
    Browse the repository at this point in the history

  2. maintainers/scripts: improve github handle checker 

    Now also finds name-clashes for github handles who never contributed to nixpkgs
before. Also deals with too many request errors.
    @Profpatsch
    Profpatsch committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    a2c708c View commit details
    Browse the repository at this point in the history

  3. lib/maintainers: correct wrong (clashing) github handles 

    Corrected every handle that had no commits to nixpkgs, manually researched the
correct handles by looking at maintained packages & blames/history on Github.
    @Profpatsch
    Profpatsch committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    8e4c39a View commit details
    Browse the repository at this point in the history

  4. lib/maintainers: add new maintainers before maintainers merge 

    Add new maintainers that were added before merging the new `maintainers.nix`
file format.
    @Profpatsch
    Profpatsch committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    aecebe8 View commit details
    Browse the repository at this point in the history

  5. lib/maintainers: rename file to maintainers-list.nix 

    Based on a request by @oxij:
“Can we also rename this file to `maintainers/maintainers-list.nix` while we at
this? Motivation: much saner `git log ./lib`.”
    @Profpatsch
    Profpatsch committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    2468400 View commit details
    Browse the repository at this point in the history