Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idea: add libsecret to the library path #36246

Merged
merged 1 commit into from Mar 3, 2018
Merged

idea: add libsecret to the library path #36246

merged 1 commit into from Mar 3, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Mar 3, 2018 •
edited

Motivation for this change

This solves the Cannot access native keychain warning from
IntelliJ-based IDEs. Previously IDEA was unable to find libsecret as
it was not part of its library path.

Please keep in mind that the keyring daemon that can be enabled on
NixOS with services.gnome3.gnome-keyring.enable = true must be
running.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ma27
idea: add libsecret to the library path
a38466a 
This solves the `Cannot access native keychain` warning from
IntelliJ-based IDEs. Previously IDEA was unable to find `libsecret` as
it was not part of its library path.

Please keep in mind that the keyring daemon that can be enabled on
NixOS with `services.gnome3.gnome-keyring.enable = true` must be
running.
@Ma27 Ma27 requested a review from edwtjo as a code owner March 3, 2018 13:42
@Mic92
Copy link
Member

Mic92 commented Mar 3, 2018

cc @edwtjo

@Mic92 Mic92 added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 3, 2018
@Mic92 Mic92 merged commit e7946b0 into NixOS:master Mar 3, 2018
@Mic92
Copy link
Member

Mic92 commented Mar 3, 2018

also backported: 1dcd022

@Ma27
Copy link
Member Author

Ma27 commented Mar 3, 2018 via email

@Ma27 Ma27 deleted the solve-keychain-issues-for-intellij branch March 3, 2018 20:17
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
@kvtb kvtb mentioned this pull request Oct 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ma27 @Mic92 @samueldr @GrahamcOfBorg