Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flameshot: 0.5.0 -> 0.5.1 #36271

Merged
merged 1 commit into from Mar 4, 2018
Merged

flameshot: 0.5.0 -> 0.5.1 #36271

merged 1 commit into from Mar 4, 2018

Conversation

scode
Copy link
Contributor

@scode scode commented Mar 3, 2018 •
edited

Motivation for this change

Upgrade.

This version might build on Darwin, but I didn't test that. The upstream patch mentioned in #34096 is rolled into this one.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (Ubuntu 17.10)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Mar 4, 2018

@GrahamcOfBorg build flameshot

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

        QDBusConnection sessionBus = QDBusConnection::sessionBus();
                                     ^
src/main.cpp:251:35: error: use of undeclared identifier 'sessionBus'
        utils.checkDBusConnection(sessionBus);
                                  ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
5 warnings and 20 errors generated.
make: *** [Makefile:1378: main.o] Error 1
builder for '/nix/store/5lgnbki85k8rpncp95qbiz44b3fas7qa-flameshot-0.5.1.drv' failed with exit code 2
error: build of '/nix/store/5lgnbki85k8rpncp95qbiz44b3fas7qa-flameshot-0.5.1.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/0hvhxcg9i834y891aqwiwm3jsd9zqrs8-flameshot-0.5.1
shrinking /nix/store/0hvhxcg9i834y891aqwiwm3jsd9zqrs8-flameshot-0.5.1/bin/flameshot
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/0hvhxcg9i834y891aqwiwm3jsd9zqrs8-flameshot-0.5.1/bin
patching script interpreter paths in /nix/store/0hvhxcg9i834y891aqwiwm3jsd9zqrs8-flameshot-0.5.1
checking for references to /build in /nix/store/0hvhxcg9i834y891aqwiwm3jsd9zqrs8-flameshot-0.5.1...
postPatchMkspecs
postPatchMkspecs
/nix/store/0hvhxcg9i834y891aqwiwm3jsd9zqrs8-flameshot-0.5.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/6z8q082sjb3091ailx3xl2r7c8i8raxv-flameshot-0.5.1
shrinking /nix/store/6z8q082sjb3091ailx3xl2r7c8i8raxv-flameshot-0.5.1/bin/flameshot
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/6z8q082sjb3091ailx3xl2r7c8i8raxv-flameshot-0.5.1/bin 
patching script interpreter paths in /nix/store/6z8q082sjb3091ailx3xl2r7c8i8raxv-flameshot-0.5.1
checking for references to /tmp/nix-build-flameshot-0.5.1.drv-0 in /nix/store/6z8q082sjb3091ailx3xl2r7c8i8raxv-flameshot-0.5.1...
postPatchMkspecs
postPatchMkspecs
/nix/store/6z8q082sjb3091ailx3xl2r7c8i8raxv-flameshot-0.5.1

@Mic92
Copy link
Member

Mic92 commented Mar 4, 2018

Can you disable darwin here and set meta.platform to platforms.linux? The build tries to use dbus - this does not exist on macOS. There is no indication of macOS support upstream.

@scode
Copy link
Contributor Author

scode commented Mar 4, 2018

@Mic92 Done.

@Mic92 Mic92 merged commit cac09e6 into NixOS:master Mar 4, 2018
@Mic92
Copy link
Member

Mic92 commented Mar 4, 2018

Thanks!

@scode scode deleted the scode/flameshot-0.5.1 branch April 16, 2018 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scode @Mic92 @GrahamcOfBorg