Python: introduce toPythonApplication function #36252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the `toPythonApplication` function. Certain Python packages are considered both a library and an application, that is, they expose importable modules, but typically executables that are part of the package are used instead. In this case, the package needs to be added to `python-packages.nix` in order for it to be available as a library. An alias with this function can then be added in `all-packages.nix`, e.g.: ``` ansible = with pythonPackages; toPythonApplication ansible; ```
|
I think you said something about also removing propagation of build inputs? |
|
Correct, but that's another step for after 18.03. |
|
Ah, nice. |
This was referenced Mar 31, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the
toPythonApplicationfunction. CertainPython packages are considered both a library and an application, that
is, they expose importable modules, but typically executables that are
part of the package are used instead.
In this case, the package needs to be added to
python-packages.nixinorder for it to be available as a library. An alias with this function
can then be added in
all-packages.nix, e.g.:Motivation for this change
See NixOS/rfcs#24.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)