Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radare2-cutter: 1.1 -> 1.2 #36251

Merged
merged 1 commit into from Mar 3, 2018
Merged

radare2-cutter: 1.1 -> 1.2 #36251

merged 1 commit into from Mar 3, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 3, 2018 •
edited

Motivation for this change

cc @dtzWill

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Mar 3, 2018

@GrahamcOfBorg build radare2-cutter

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘radare2-2.3.0’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/tools/analysis/radare2/default.nix:50 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘radare2-2.3.0’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/tools/analysis/radare2/default.nix:50 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/9fgv6jvdfg60fx8ddfv7qqvbqcgrh4hh-radare2-cutter-1.2
shrinking /nix/store/9fgv6jvdfg60fx8ddfv7qqvbqcgrh4hh-radare2-cutter-1.2/bin/cutter
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/9fgv6jvdfg60fx8ddfv7qqvbqcgrh4hh-radare2-cutter-1.2/bin 
patching script interpreter paths in /nix/store/9fgv6jvdfg60fx8ddfv7qqvbqcgrh4hh-radare2-cutter-1.2
checking for references to /tmp/nix-build-radare2-cutter-1.2.drv-0 in /nix/store/9fgv6jvdfg60fx8ddfv7qqvbqcgrh4hh-radare2-cutter-1.2...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/9fgv6jvdfg60fx8ddfv7qqvbqcgrh4hh-radare2-cutter-1.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/9fgv6jvdfg60fx8ddfv7qqvbqcgrh4hh-radare2-cutter-1.2

@Mic92 Mic92 merged commit 62a5943 into NixOS:master Mar 3, 2018
@Mic92 Mic92 deleted the radare2-cutter branch March 3, 2018 15:38
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/fa39xibhn3l5q7ix7hnlgc92az039dlf-radare2-cutter-1.2
shrinking /nix/store/fa39xibhn3l5q7ix7hnlgc92az039dlf-radare2-cutter-1.2/bin/cutter
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/fa39xibhn3l5q7ix7hnlgc92az039dlf-radare2-cutter-1.2/bin
patching script interpreter paths in /nix/store/fa39xibhn3l5q7ix7hnlgc92az039dlf-radare2-cutter-1.2
checking for references to /build in /nix/store/fa39xibhn3l5q7ix7hnlgc92az039dlf-radare2-cutter-1.2...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/fa39xibhn3l5q7ix7hnlgc92az039dlf-radare2-cutter-1.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

these derivations will be built:
  /nix/store/m16i227f3izx0l56m56hm1m06ff6sm3a-qtbase-5.10.1.drv
  /nix/store/97k2717825xb4hvr95nn2nxkn966s54p-hook.drv
  /nix/store/yx6hwhqly8kyb9cg3x5agm74alsvwq9q-qtsvg-5.10.1.drv
  /nix/store/zwm3d35k9dx09r5nhaayqc7dna21gxil-radare2-cutter-1.2.drv
waiting for locks or build slots...
/nix/store/fa39xibhn3l5q7ix7hnlgc92az039dlf-radare2-cutter-1.2

@dtzWill
Copy link
Member

dtzWill commented Mar 3, 2018 •
edited

#33198 (comment) :(

What I remember of the details:

  • desktop file is broken-- submitted issue and upstream fixed it (trivial capitalization problem)
  • top bar is too small / cuts off text within

IIRC it also died on some inputs that worked previously, but I can't find them currently.

Upstream seems to have fixed both of these, but also requires using a newer radare2.

Tried git version ~2 weeks ago, here's that branch: https://github.com/dtzWill/nixpkgs/tree/feature/r2-cutter-1.2-git .

Will update to latest git shortly and see how that goes...

  • Updating and rebasing branch, so here's the reference to the commit mentioned above: dtzWill@aa951be
  • It requires git versions of a few things, not sure this should be default.

Hopefully they cut a new release soon? :) They (and radare2) move pretty fast, past 3 releases were ~1 mo apart and last was in January.

Don't feel strongly about what to do here, my inclination is to keep things simple and just move to update when it is available.

@Mic92
Copy link
Member Author

Mic92 commented Mar 3, 2018

@dtzWill should I revert this update?

@dtzWill
Copy link
Member

dtzWill commented Mar 3, 2018

I suppose so, yes, but I'm happy leaving it as-is as well. It's not the /most/ broken :). Thanks!

@Mic92
Copy link
Member Author

Mic92 commented Mar 4, 2018

@dtzWill see c16936c

Mic92 added a commit that referenced this pull request Mar 4, 2018
@Mic92
Revert "radare2-cutter: 1.1 -> 1.2"
c16936c 
This reverts commit 664deab.

reason: #36251 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @GrahamcOfBorg @dtzWill