lib: rename maintainers-list.nix into maintainers/maintainer-list.nix #36275
Conversation
|
The ofborg error is pretty interesting. What is this? I don't even. |
oxij
force-pushed
the
lib/maintainers-list
branch
3 times, most recently
from
86cc5c6
to
94453db
Compare
|
Maybe it has something to do with the change to |
|
Nah, now it's bugs in derivations. Will fix one by one as obborg finds them. |
|
Ah, but then this should be two PRs, really. |
|
The error is on master, not on your branch. The original PR didn't pass checks, and ofborg doesn't handle it well when master is already broken. |
|
All the things evaluate here. @grahamc or @Profpatsch can you pick up two top commits from here to master? I will then rebase to clean this up to match the topic. |
oxij
force-pushed
the
lib/maintainers-list
branch
from
b166fa9
to
3521a52
Compare
|
I pushed the last two, but I think you meant the last three? |
|
Rebased onto #36279. |
|
@grahamc Well, yes (I need to go to sleep ASAP, I guess). Anyway, this branch looks good to me. Waiting for ofborg. |
|
Yay! This now closes #36279, I guess. |
|
Okay, the broken evaluations have been fixed in #36279. |
oxij
force-pushed
the
lib/maintainers-list
branch
from
3521a52
to
4e06e9e
Compare
|
I wonder why it worked without f56dc5213adaa51c854b6889f77be40bc9ddf7a4.
|
oxij
force-pushed
the
lib/maintainers-list
branch
2 times, most recently
from
39ddf56
to
70fab9e
Compare
|
Updated a bit. Why? Because `find . -iname '*-list*.nix'` now shows this:
```
./maintainers/maintainer-list.nix
./lib/tests/modules/define-value-list.nix
./nixos/modules/module-list.nix
```
|
oxij
changed the title
oxij
force-pushed
the
lib/maintainers-list
branch
from
70fab9e
to
0a0a5ed
Compare
Many commits unrelated to `lib` touch that file, this will make `git log ./lib` much saner. This is what I meant in NixOS#36119 (comment).
oxij
force-pushed
the
lib/maintainers-list
branch
from
0a0a5ed
to
610b5b8
Compare
|
ping |
|
@GrahamcOfBorg eval |
lib: rename maintainers-list.nix into maintainers/maintainer-list.nix (cherry picked from commit 1bd790d) The intention is to reduce conflicts during maintenance.
Much saner
git log ./lib.