Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

desmume: avoid errors with with -fpermissive #36276

Merged
merged 1 commit into from Mar 4, 2018
Merged

desmume: avoid errors with with -fpermissive #36276

merged 1 commit into from Mar 4, 2018

Conversation

eqyiel
Copy link
Contributor

@eqyiel eqyiel commented Mar 4, 2018

Prior to this change, desmume would fail to build on nixos-unstable due to an error:

utils/libfat/directory.cpp:142:33: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]

I guess this is due to the recent switch to GCC7.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@eqyiel
desmume: avoid errors with with -fpermissive
688aaf1 
Prior to this change, desmume would fail to build due to an error:

utils/libfat/directory.cpp:142:33: error: ISO C++ forbids comparison between
  pointer and integer [-fpermissive]
@eqyiel
Copy link
Contributor Author

eqyiel commented Mar 4, 2018

😿 I'm pretty sure that evaluation error is unrelated, it builds and runs fine from this branch locally.

@grahamc
Copy link
Member

grahamc commented Mar 4, 2018

@GrahamcOfBorg eval

Yeah, a PR mistakenly broke master :) Should be fixed up now. Sorry!

@Mic92
Copy link
Member

Mic92 commented Mar 4, 2018

@GrahamcOfBorg build desmume

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘desmume-0.9.11’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/misc/emulators/desmume/default.nix:44 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/q9az497sqn6zpn5hsn5v8c1q5lcppp75-desmume-0.9.11
shrinking /nix/store/q9az497sqn6zpn5hsn5v8c1q5lcppp75-desmume-0.9.11/bin/desmume-cli
shrinking /nix/store/q9az497sqn6zpn5hsn5v8c1q5lcppp75-desmume-0.9.11/bin/desmume
gzipping man pages under /nix/store/q9az497sqn6zpn5hsn5v8c1q5lcppp75-desmume-0.9.11/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/q9az497sqn6zpn5hsn5v8c1q5lcppp75-desmume-0.9.11/bin 
patching script interpreter paths in /nix/store/q9az497sqn6zpn5hsn5v8c1q5lcppp75-desmume-0.9.11
checking for references to /tmp/nix-build-desmume-0.9.11.drv-0 in /nix/store/q9az497sqn6zpn5hsn5v8c1q5lcppp75-desmume-0.9.11...
/nix/store/q9az497sqn6zpn5hsn5v8c1q5lcppp75-desmume-0.9.11

@Mic92 Mic92 merged commit e6b6784 into NixOS:master Mar 4, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ibfq95ym5gs9mbc1q5hac2glvykxgnc9-desmume-0.9.11
shrinking /nix/store/ibfq95ym5gs9mbc1q5hac2glvykxgnc9-desmume-0.9.11/bin/desmume-cli
shrinking /nix/store/ibfq95ym5gs9mbc1q5hac2glvykxgnc9-desmume-0.9.11/bin/desmume
gzipping man pages under /nix/store/ibfq95ym5gs9mbc1q5hac2glvykxgnc9-desmume-0.9.11/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/ibfq95ym5gs9mbc1q5hac2glvykxgnc9-desmume-0.9.11/bin
patching script interpreter paths in /nix/store/ibfq95ym5gs9mbc1q5hac2glvykxgnc9-desmume-0.9.11
checking for references to /build in /nix/store/ibfq95ym5gs9mbc1q5hac2glvykxgnc9-desmume-0.9.11...
/nix/store/ibfq95ym5gs9mbc1q5hac2glvykxgnc9-desmume-0.9.11

@eqyiel
Copy link
Contributor Author

eqyiel commented Mar 4, 2018

@grahamc @Mic92 thanks!

@eqyiel eqyiel deleted the fix-desmume branch March 4, 2018 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eqyiel @grahamc @Mic92 @GrahamcOfBorg