mycroft: init at 0.9.19 [WIP] #36248

peterhoeg · 2018-03-03T14:20:04Z

Motivation for this change

Well, who doesn't want AI on your NixOS machine?

This is VERY much WIP but let's get it out there as soon as possible.

What works:

The services can be run manually or using the systemd services
Everything comes up (and doesn't crash) when run inside a VM using nixos-rebuild build-vm.

But I don't actually know if it works, because there are a number of things that need to be fixed first:

We need to handle how to run a pulseaudio instance when it's not running inside the user session
All the python packages need to be separated out into their own packages
Tests need to be enabled for the various packages (I just disabled them if they were causing problems)
Mycroft itself has 2 failing tests - I haven't looked at all at why that isn't working
The skill script (msm) is borked (and not in the right place)
Need to figure out a way to have skills that are preloaded merged with skills dynamically installed - probably unionfs
Enclouse daemon isn't working

Cc: @dotlambda @bjornfor

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

oxij · 2018-03-03T15:41:51Z

Can you, please, elaborate on PulseAudio issue?

peterhoeg · 2018-03-04T01:14:35Z

Can you, please, elaborate on PulseAudio issue?

Sure - it isn't actually so much of a pulseaudio issue as it's a "which run-mode do we use". Mycroft needs to run as an unprivileged user and we can do this in 3 ways: 1. A normal script fired off by a user (this is what happens when you run the upstream-sanctioned start-mycroft.sh) which backgrounds a bunch of services. This is pretty ugly but allows mycroft to interact with the user's running pulseaudio instance. 2. A bunch of systemd user services which can also talk to the user's pulseaudio instance. 3. A bunch of systemd *system* services that require a system-wide pulseaudio instance. So either mycroft should run in "appliance mode" if deployed to a Raspberry Pi or similar or in user-mode when used by a regular user. We then have to bring in pulseaudio in system mode if running as an appliance and probably fiddle that paths if running in user-mode.

peterhoeg · 2018-03-04T01:22:03Z

Cc: @FRidh as main python guy around here

dotlambda · 2018-03-04T11:13:16Z

nixos/modules/services/misc/mycroft.nix

+
+    systemd = {
+      packages = with pkgs; [ mycroft ];
+      targets.mycroft.wantedBy = lib.mkIf cfg.applianceMode [ "multi-user.target" ];


If I understand it correctly, nothing is run if services.mycroft.enable = true. What's the purpose of having two "enable" options, then?

peterhoeg · 2018-03-04T13:29:24Z

true. What's the purpose of having two "enable" options, then?

It gives you access to the systemd units so you can do this: ``` shell systemctl --user start mycroft.target ``` It seems a little heavy-handed to enable it for ALL users.

matthiasbeyer · 2018-03-19T17:58:55Z

Hi, I'm excited about this PR. I have some questions:

What does the mycroft-cli actually do? Does it run a mycroft instance, so am I able to use this for a first test of mycroft?
What STT engine is used by this package as default? I don't want any $bigCorp to listen, so does this use the mozilla speech recognition system on my own hardware without accessing the internet? If not, maybe this would be a nice idea as a package/service parameter/option.

I get (from mycroft-voice):

Exception in thread Thread-15:
Traceback (most recent call last):
  File "/nix/store/7b2z0vfbs9539ga4pxx5gmli47rz5y3n-python-2.7.14/lib/python2.7/threading.py", line 801, in __bootstrap_inner
    self.run()
  File "/nix/store/p3v2cbsczdhn494s4bq2j7a5hjn2g38p-mycroft-0.9.19/lib/python2.7/site-packages/mycroft/client/speech/listener.py", line 58, in run
    audio = self.recognizer.listen(source, self.emitter)
  File "/nix/store/p3v2cbsczdhn494s4bq2j7a5hjn2g38p-mycroft-0.9.19/lib/python2.7/site-packages/mycroft/client/speech/mic.py", line 537, in listen
    play_wav(file)
  File "/nix/store/p3v2cbsczdhn494s4bq2j7a5hjn2g38p-mycroft-0.9.19/lib/python2.7/site-packages/mycroft/util/__init__.py", line 86, in play_wav
    return subprocess.Popen(play_wav_cmd)
  File "/nix/store/7b2z0vfbs9539ga4pxx5gmli47rz5y3n-python-2.7.14/lib/python2.7/subprocess.py", line 390, in __init__
    errread, errwrite)
  File "/nix/store/7b2z0vfbs9539ga4pxx5gmli47rz5y3n-python-2.7.14/lib/python2.7/subprocess.py", line 1025, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

When saying Hey mycroft.

I also get

19:10:52.260 - __main__:download_skills:338 - ERROR - Unable to invoke Mycroft Skill Manager: /nix/store/p3v2cbsczdhn494s4bq2j7a5hjn2g38p-mycroft-0.9.19/msm/msm

from mycroft-skills.

(I started each mycroft module individually from the ./result directory, I did not install it in my system or rebuild my system with it).

I just noticed that mycroft created a directory with the name 1{HOME:- in my nixpkgs directory. That is propably a bug in the package.

matthiasbeyer · 2018-03-19T18:50:37Z

Please cherry-pick f39e151659f from my fork of nixpkgs.

matthiasbeyer · 2018-03-19T19:05:59Z

Please cherry-pick 4b14f3ebd28 as well.

matthiasbeyer · 2018-03-19T19:16:50Z

Please cherry-pick b019aaa782a as well.

This works for me now. Mycroft cannot understand me, but it at least works.

matthiasbeyer · 2018-03-19T19:25:07Z

Hm, the HOME variable setting is still bogus, but it works for me anyways. You propably should have a look at it again.

I pushed another change of the HOME variable thing in 20a71005ccf67dc4c7b519565e7cb61706630306

Propably not the right solution, though.

peterhoeg · 2018-03-20T00:28:47Z

Thanks for trying things out. I had hoped to have it ready for 18.03 but I need to throw some time at it this weekend.

I pushed another change of the HOME variable thing in 20a7100

The escaping is wrong. Should be ''$. Anyway, I'll fix that.

matthiasbeyer · 2018-11-01T18:12:14Z

Any updates on this?

peterhoeg · 2018-11-02T01:44:45Z

Unfortunately not. And I know a lot has changed upstream as well.

FRidh · 2019-01-06T12:33:55Z

Closing due to inactivity.

timokau · 2020-05-11T20:21:31Z

Related: #87621

peterhoeg requested a review from FRidh as a code owner March 3, 2018 14:20

GrahamcOfBorg added 6.topic: nixos 6.topic: python 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 3, 2018

peterhoeg force-pushed the p/mycroft branch from 9890911 to 36c4f99 Compare March 4, 2018 07:57

peterhoeg added 5 commits March 4, 2018 17:16

mycroft: init at 0.9.19

a58919c

mimic: init at 1.2.0.2

92198de

pythonPackages.pyalsaaudio: init at 0.8.4

65426fa

pythonpackages.pyaudio: use fetchPypi so we can override it

2becf1a

mycroft module

3e70bc5

peterhoeg force-pushed the p/mycroft branch from 36c4f99 to 3e70bc5 Compare March 4, 2018 09:17

dotlambda reviewed Mar 4, 2018

View reviewed changes

peterhoeg added 3 commits March 5, 2018 10:02

mimic

9ddf571

voice

b731d82

pkgs basedir

9266b11

matthewbauer added the 2.status: work-in-progress label Mar 22, 2018

samueldr added the 2.status: merge conflict label Nov 11, 2018

FRidh closed this Jan 6, 2019

jtojnar mentioned this pull request Nov 20, 2019

Package request: mycroft-core,mycroft-gui #73769

Open

davidak mentioned this pull request Mar 3, 2022

Mycroft #161596

Closed

13 tasks

peterhoeg deleted the p/mycroft branch April 4, 2024 08:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mycroft: init at 0.9.19 [WIP] #36248

mycroft: init at 0.9.19 [WIP] #36248

peterhoeg commented Mar 3, 2018 •

edited

oxij commented Mar 3, 2018 via email

peterhoeg commented Mar 4, 2018 via email

peterhoeg commented Mar 4, 2018

dotlambda Mar 4, 2018

peterhoeg commented Mar 4, 2018 via email

matthiasbeyer commented Mar 19, 2018 •

edited

matthiasbeyer commented Mar 19, 2018

matthiasbeyer commented Mar 19, 2018

matthiasbeyer commented Mar 19, 2018

matthiasbeyer commented Mar 19, 2018 •

edited

peterhoeg commented Mar 20, 2018

matthiasbeyer commented Nov 1, 2018

peterhoeg commented Nov 2, 2018

FRidh commented Jan 6, 2019

timokau commented May 11, 2020

mycroft: init at 0.9.19 [WIP] #36248

mycroft: init at 0.9.19 [WIP] #36248

Conversation

peterhoeg commented Mar 3, 2018 • edited

Motivation for this change

Things done

oxij commented Mar 3, 2018 via email

peterhoeg commented Mar 4, 2018 via email

peterhoeg commented Mar 4, 2018

dotlambda Mar 4, 2018

Choose a reason for hiding this comment

peterhoeg commented Mar 4, 2018 via email

matthiasbeyer commented Mar 19, 2018 • edited

matthiasbeyer commented Mar 19, 2018

matthiasbeyer commented Mar 19, 2018

matthiasbeyer commented Mar 19, 2018

matthiasbeyer commented Mar 19, 2018 • edited

peterhoeg commented Mar 20, 2018

matthiasbeyer commented Nov 1, 2018

peterhoeg commented Nov 2, 2018

FRidh commented Jan 6, 2019

timokau commented May 11, 2020

peterhoeg commented Mar 3, 2018 •

edited

matthiasbeyer commented Mar 19, 2018 •

edited

matthiasbeyer commented Mar 19, 2018 •

edited