ansible-lint: init at 3.4.20 #36250
ansible-lint: init at 3.4.20 #36250
Conversation
lib/maintainers.nix
Outdated
| @@ -712,6 +712,7 @@ | |||
| timor = "timor <timor.dd@googlemail.com>"; | |||
| tiramiseb = "Sébastien Maccagnoni <sebastien@maccagnoni.eu>"; | |||
| titanous = "Jonathan Rudenberg <jonathan@titanous.com>"; | |||
| tlo = "Thilo Uttendorfer <tlo@sengaya.de>"; | |||
There was a problem hiding this comment.
please use your github handle here instead
| { stdenv, pythonPackages, fetchurl, ansible }: | ||
|
|
||
| pythonPackages.buildPythonPackage rec { | ||
| name = "ansible-lint-${version}"; |
There was a problem hiding this comment.
The name attribute is added by buildPython* and should therefore be removed.
| name = "ansible-lint-${version}"; | ||
| version = "3.4.20"; | ||
|
|
||
| src = fetchurl { |
There was a problem hiding this comment.
fetchPypi is preferred unless tests are not included
| sha256 = "b7fb92f00b9723e3a9624d70b53b60db41426c0ef4fad05ab28c7e4f28a0b6e2"; | ||
| }; | ||
|
|
||
| propagatedBuildInputs = with pythonPackages; [ pyyaml six ] ++ [ ansible ]; |
There was a problem hiding this comment.
This is going to be interesting, as ansible is used here as a module. In order to make this reliably work we should make ansible a Python library instead of an application.
|
@FRidh Thanks for the feedback, much appreciated! With fetchPypi I get an error similar to #29169 I probably need some help with the "make ansible a lib" topic. Should there be two packages, something like libansible and ansible? Is there a comparable package in nixpkgs where I could have a look? |
sengaya
force-pushed
the
add-ansible-lint
branch
from
d6240a5
to
239b8ff
Compare
sengaya
force-pushed
the
add-ansible-lint
branch
from
239b8ff
to
861e2de
Compare
ansible-lint: init at 3.4.20 (cherry picked from commit 07bc1dd)
Motivation for this change
Add ansible-lint, a linter for ansible playbooks
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)