Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kitty: 0.7.1 -> 0.8.0 #36264

Merged
merged 1 commit into from Mar 4, 2018
Merged

kitty: 0.7.1 -> 0.8.0 #36264

merged 1 commit into from Mar 4, 2018

Conversation

tex
Copy link
Contributor

@tex tex commented Mar 3, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Mar 3, 2018

Changelog: https://github.com/kovidgoyal/kitty/blob/v0.8.0/CHANGELOG.rst#version-080-2018-02-24

@Mic92
Copy link
Member

Mic92 commented Mar 4, 2018

@GrahamcOfBorg build kitty

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘kitty-0.8.0’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/applications/misc/kitty/default.nix:39 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/1wmdqk16wpab3bchbi61y9vajm0l4ql7-kitty-0.8.0
shrinking /nix/store/1wmdqk16wpab3bchbi61y9vajm0l4ql7-kitty-0.8.0/lib/kitty/kittens/unicode_input/unicode_names.so
shrinking /nix/store/1wmdqk16wpab3bchbi61y9vajm0l4ql7-kitty-0.8.0/lib/kitty/kitty/fast_data_types.so
shrinking /nix/store/1wmdqk16wpab3bchbi61y9vajm0l4ql7-kitty-0.8.0/lib/kitty/kitty/glfw-x11.so
shrinking /nix/store/1wmdqk16wpab3bchbi61y9vajm0l4ql7-kitty-0.8.0/bin/.kitty-wrapped
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/1wmdqk16wpab3bchbi61y9vajm0l4ql7-kitty-0.8.0/lib  /nix/store/1wmdqk16wpab3bchbi61y9vajm0l4ql7-kitty-0.8.0/bin
patching script interpreter paths in /nix/store/1wmdqk16wpab3bchbi61y9vajm0l4ql7-kitty-0.8.0
checking for references to /build in /nix/store/1wmdqk16wpab3bchbi61y9vajm0l4ql7-kitty-0.8.0...
/nix/store/1wmdqk16wpab3bchbi61y9vajm0l4ql7-kitty-0.8.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/pyy85kqjlqywddpq82myg92sjk5d88bf-kitty-0.8.0
shrinking /nix/store/pyy85kqjlqywddpq82myg92sjk5d88bf-kitty-0.8.0/bin/.kitty-wrapped
shrinking /nix/store/pyy85kqjlqywddpq82myg92sjk5d88bf-kitty-0.8.0/lib/kitty/kittens/unicode_input/unicode_names.so
shrinking /nix/store/pyy85kqjlqywddpq82myg92sjk5d88bf-kitty-0.8.0/lib/kitty/kitty/fast_data_types.so
shrinking /nix/store/pyy85kqjlqywddpq82myg92sjk5d88bf-kitty-0.8.0/lib/kitty/kitty/glfw-x11.so
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/pyy85kqjlqywddpq82myg92sjk5d88bf-kitty-0.8.0/lib  /nix/store/pyy85kqjlqywddpq82myg92sjk5d88bf-kitty-0.8.0/bin 
patching script interpreter paths in /nix/store/pyy85kqjlqywddpq82myg92sjk5d88bf-kitty-0.8.0
checking for references to /tmp/nix-build-kitty-0.8.0.drv-0 in /nix/store/pyy85kqjlqywddpq82myg92sjk5d88bf-kitty-0.8.0...
/nix/store/pyy85kqjlqywddpq82myg92sjk5d88bf-kitty-0.8.0

@Mic92 Mic92 merged commit 7f3dab4 into NixOS:master Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tex @jtojnar @Mic92 @GrahamcOfBorg