Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxHeaders: Bump default to 4.15. #35150

Merged
merged 1 commit into from Feb 19, 2018
Merged

linuxHeaders: Bump default to 4.15. #35150

merged 1 commit into from Feb 19, 2018

Conversation

shlevy
Copy link
Member

@shlevy shlevy commented Feb 18, 2018

No description provided.

@shlevy shlevy requested a review from vcunat February 18, 2018 22:00
@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

error: while evaluating 'callPackagesWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:123:36, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:12953:12:
while evaluating 'mapAttrs' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/attrsets.nix:198:17, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:130:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel-headers/default.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:128:14:
assertion failed at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel-headers/default.nix:6:1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

  INSTALL include/rdma (20 files)
  INSTALL include/rdma/hfi (2 files)
  INSTALL include/scsi (4 files)
  INSTALL include/scsi/fc (4 files)
  INSTALL include/sound (15 files)
  INSTALL include/video (3 files)
  INSTALL include/xen (4 files)
  INSTALL include/asm (63 files)
post-installation fixup
/nix/store/c0agpb1m0vsn2rnwjgi3zazvwn8rwi8p-linux-headers-4.15

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

  INSTALL include/rdma (20 files)
  INSTALL include/rdma/hfi (2 files)
  INSTALL include/scsi (4 files)
  INSTALL include/scsi/fc (4 files)
  INSTALL include/sound (15 files)
  INSTALL include/video (3 files)
  INSTALL include/xen (4 files)
  INSTALL include/asm (36 files)
post-installation fixup
/nix/store/riq6d3andbbgk9jr78h7yplpxzqg07x2-linux-headers-4.15

@dtzWill
Copy link
Member

dtzWill commented Feb 19, 2018

Will binaries built using newer headers have problems executing on older kernels?

@shlevy
Copy link
Member Author

shlevy commented Feb 19, 2018

No, we set a minimum version for glibc (3.2.0).

vcunat
vcunat approved these changes Feb 19, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds OK to me. 4.14 would feel more natural, as that's longterm and we plan to switch to it, but I know of no downside using 4.15 for headers instead.

@shlevy shlevy merged commit fd0f15f into NixOS:staging Feb 19, 2018
@shlevy shlevy deleted the linux-headers-4.15 branch February 19, 2018 15:10
@dtzWill
Copy link
Member

dtzWill commented Feb 19, 2018

So I re-introduced the notion of different headers as part of musl work, so as to avoid causing problems (or reviewer burden to "prove" such did not exist) on other configurations/architectures/platforms....
This especially made sense as early on I was using either patched 4.14 headers or 4.15 RC's which were particularly poorly motivated as a new default 😁.

Would it make sense to go back to having single version, now that this is merged?

@shlevy
Copy link
Member Author

shlevy commented Feb 19, 2018

@dtzWill Might be nice to have it be clear how we can add a new version in the future, but no strong opinions there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shlevy @GrahamcOfBorg @dtzWill @vcunat