Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtmanager: 1.4.3 -> 1.5.0, cleanup dependencies #35151

Merged
merged 6 commits into from Feb 23, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Feb 18, 2018

remove unneeded dependencies.
closes issue #34043

Motivation for this change
Things done
  • [] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

/cc maintainers: @qknight @offlinehacker @fpletz

remove unneeded dependencies, see issue NixOS#34043
otherwise virt-manager startup fails with
Typelib file for namespace 'Pango', version '1.0' not found: Could not open display: :0
@xeji
Copy link
Contributor Author

xeji commented Feb 19, 2018

@GrahamcOfBorg eval

@jtojnar
Copy link
Contributor

jtojnar commented Feb 19, 2018

@GrahamcOfBorg eval

@joachifm
Copy link
Contributor

@GrahamcOfBorg build virtmanager

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘libvirt-glib-1.0.0’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/libraries/libvirt-glib/default.nix:27 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@xeji
Copy link
Contributor Author

xeji commented Feb 19, 2018

The libvirt-glib dependency isn't new and explicitly required in virt-manager source. Don't think we can change that.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

   Compiling compiler_builtins v0.0.0 (file:///build/rustc-1.22.1-src/src/rustc/compiler_builtins_shim)
   Compiling std v0.0.0 (file:///build/rustc-1.22.1-src/src/libstd)
building of '/nix/store/6l7diahpwvbvv3dv15yxq8naazvzl94n-rustc-1.22.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/s0giclzdy862yfnhm4x52fkxr1z4jdd9-cargo-0.23.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/zgas64322n7nnrcwfmsd2gi8aqp1m3hr-librsvg-2.42.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/h3dxkc87yq4bhp777sq19q6hz2g0r385-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/cfqmms98nnxv2q2993alv14lb3xnav2a-icon-naming-utils-0.8.90.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ikl6s98pwaqpib7bh7wghg1ikwbwp02a-adwaita-icon-theme-3.26.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/j7cp9jnkkb4d4ld3crbj0hchgc4w5dqm-virt-manager-1.5.0.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/j7cp9jnkkb4d4ld3crbj0hchgc4w5dqm-virt-manager-1.5.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

test [run-pass] run-pass/option-ext.rs ... ok
test [run-pass] run-pass/or-pattern.rs ... ok
building of '/nix/store/lw134l3lsb32i3a2krqjqlg5yhrwmi6k-rustc-1.22.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/rsa0iw5248y9xiqp44vra7vb36zh74js-cargo-0.23.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/3b5ydbhwcr6gklj898xrw1v3xzwic9qy-librsvg-2.42.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/6xqc0s5nfjkn75laj5wz6q2cjcm1nw4l-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/6fsa61gk1ji9dl1hk8jymdl39d4p0ymz-icon-naming-utils-0.8.90.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/psv987cpmhwhmmx9bnz0r11dq73p19wc-adwaita-icon-theme-3.26.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/y5slgs1av0ks39lyljjp2614hgk2y57d-virt-manager-1.5.0.drv': 2 dependencies couldn't be built
error: build of '/nix/store/y5slgs1av0ks39lyljjp2614hgk2y57d-virt-manager-1.5.0.drv' failed

@jtojnar
Copy link
Contributor

jtojnar commented Feb 19, 2018

@xeji
Copy link
Contributor Author

xeji commented Feb 19, 2018

@jtojnar so should we exclude darwin in virtmanager for the time being?

@jtojnar
Copy link
Contributor

jtojnar commented Feb 19, 2018

@xeji We could just ignore it for now. Though if you want, you could try changing the platforms attribute to unix, libvirt is supposed to support Darwin (https://libvirt.org/).

platforms: linux -> unix to see if it builds on Darwin
@jtojnar
Copy link
Contributor

jtojnar commented Feb 20, 2018

@GrahamcOfBorg build virtmanager

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘libcap-ng-0.7.8’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/libcap-ng/default.nix:34 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@xeji
Copy link
Contributor Author

xeji commented Feb 20, 2018

@jtojnar this seems to be more complicated on Darwin. Let's reverse the last commit and set platforms=linux in virtmanager as well. If anyone needs this on Darwin, they can figure it out.

... but it doesn't (needs libcap-ng)

This reverts commit 7795947.
since dependency libvirt-glib currently doesn't build on Darwin
@jtojnar
Copy link
Contributor

jtojnar commented Feb 20, 2018

@GrahamcOfBorg build virtmanager

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

   Compiling proc_macro v0.0.0 (file:///build/rustc-1.24.0-src/src/libproc_macro)
   Compiling syntax_ext v0.0.0 (file:///build/rustc-1.24.0-src/src/libsyntax_ext)
building of '/nix/store/mvg072gpj8hci2n8y958y4cswhpmhm3b-rustc-1.24.0.drv' timed out after 3200 seconds
cannot build derivation '/nix/store/8cj81hqyhnklzb11v9nm9i7ilxm783q1-cargo-0.24.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/c9l67a987hcl2c3m0s26m0l30armhr5n-librsvg-2.42.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/rrii2ih9mawjxmx16vfdi1rl26wkdv53-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/7y5rjf7knsr732f7z4mxgn814242wp03-icon-naming-utils-0.8.90.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/d2mbwbsdasd85achi398prnfc8l5ip1j-adwaita-icon-theme-3.26.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/9iib7zizk6c8vz9klaxinfqgaiycp5vz-virt-manager-1.5.0.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/9iib7zizk6c8vz9klaxinfqgaiycp5vz-virt-manager-1.5.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

test [compile-fail] compile-fail-fulldeps/plugin-plus-extern-crate.rs ... ok
test [compile-fail] compile-fail-fulldeps/proc-macro/feature-gate-proc_macro.rs ... ok
building of '/nix/store/2nc60icc2px3rxppyhg7xha6kskhnz55-rustc-1.24.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/395mrkfxi7jjqnciqhlxrjnyiija6p2w-cargo-0.24.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/60v9zv5mc5yp57wl55bwk82ixzn1nmmf-librsvg-2.42.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/3d7ibcivc2psm4innm7nwz0qdwgh0lj4-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/m19am2ma00n12vssqa1cindi8glimys4-icon-naming-utils-0.8.90.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/qdrf8ia1bazbgvhvi1bsaaqfd02c9xdv-adwaita-icon-theme-3.26.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/izrn4jkpw61g9yqqq7w46cwcshj8l9yg-virt-manager-1.5.0.drv': 2 dependencies couldn't be built
error: build of '/nix/store/izrn4jkpw61g9yqqq7w46cwcshj8l9yg-virt-manager-1.5.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘virt-manager-1.5.0’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/virtualization/virt-manager/default.nix:57 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

   Compiling rustc_llvm v0.0.0 (file:///tmp/nix-build-rustc-1.24.0.drv-0/rustc-1.24.0-src/src/librustc_llvm)
   Compiling flate2 v1.0.1
building of ‘/nix/store/dil6afzbzg706hn0i7drv8hsi82ad1z3-rustc-1.24.0.drv’ timed out after 3600 seconds
cannot build derivation ‘/nix/store/if8q6nyiqp1n4jn1kk73lhxm843kphh6-cargo-0.24.0.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/m9q3fyv6ziqk3lwsihfx8z9yqn50al68-librsvg-2.42.2.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/0p3r7mh667gmxl97j8rz2h84bfij7bd5-hook.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/ydcxlqfpk14r06cqk1c5iwik0swnwj72-icon-naming-utils-0.8.90.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/s3qw4z5wwqya74qhxc0gyihhqsx39166-adwaita-icon-theme-3.26.1.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/vggdgbgfi3p1ia3q5mr1dxz2i2c2m71y-virt-manager-1.5.0.drv’: 2 dependencies couldn't be built
error: build of ‘/nix/store/vggdgbgfi3p1ia3q5mr1dxz2i2c2m71y-virt-manager-1.5.0.drv’ failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

   Compiling rustc_const_math v0.0.0 (file:///build/rustc-1.24.0-src/src/librustc_const_math)
   Compiling syntax_ext v0.0.0 (file:///build/rustc-1.24.0-src/src/libsyntax_ext)
building of '/nix/store/mvg072gpj8hci2n8y958y4cswhpmhm3b-rustc-1.24.0.drv' timed out after 3200 seconds
cannot build derivation '/nix/store/8cj81hqyhnklzb11v9nm9i7ilxm783q1-cargo-0.24.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/c9l67a987hcl2c3m0s26m0l30armhr5n-librsvg-2.42.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/rrii2ih9mawjxmx16vfdi1rl26wkdv53-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/7y5rjf7knsr732f7z4mxgn814242wp03-icon-naming-utils-0.8.90.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/d2mbwbsdasd85achi398prnfc8l5ip1j-adwaita-icon-theme-3.26.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/9iib7zizk6c8vz9klaxinfqgaiycp5vz-virt-manager-1.5.0.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/9iib7zizk6c8vz9klaxinfqgaiycp5vz-virt-manager-1.5.0.drv' failed

@xeji
Copy link
Contributor Author

xeji commented Feb 20, 2018

Build fails on linux apparently caused by: rustc-1.24 build timeout.
@Mic92 could that be related to f61e8d9 ?

@Mic92
Copy link
Member

Mic92 commented Feb 20, 2018

@xeji hopefully resolved soon, when hydra catches up.

@jtojnar
Copy link
Contributor

jtojnar commented Feb 22, 2018

@GrahamcOfBorg build virtmanager

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘virt-manager-1.5.0’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/virtualization/virt-manager/default.nix:57 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/4clwsjyapkbv7z2bhfr9jv5hwywwabsq-virt-manager-1.5.0/bin/.virt-install-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
/nix/store/4clwsjyapkbv7z2bhfr9jv5hwywwabsq-virt-manager-1.5.0/bin/.virt-clone-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
/nix/store/4clwsjyapkbv7z2bhfr9jv5hwywwabsq-virt-manager-1.5.0/bin/.virt-convert-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
/nix/store/4clwsjyapkbv7z2bhfr9jv5hwywwabsq-virt-manager-1.5.0/bin/.virt-xml-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
/nix/store/4clwsjyapkbv7z2bhfr9jv5hwywwabsq-virt-manager-1.5.0/share/virt-manager/virt-install: interpreter directive changed from "/usr/bin/env python2" to "/nix/store/7b2z0vfbs9539ga4pxx5gmli47rz5y3n-python-2.7.14/bin/python2"
/nix/store/4clwsjyapkbv7z2bhfr9jv5hwywwabsq-virt-manager-1.5.0/share/virt-manager/virt-manager: interpreter directive changed from "/usr/bin/env python2" to "/nix/store/7b2z0vfbs9539ga4pxx5gmli47rz5y3n-python-2.7.14/bin/python2"
/nix/store/4clwsjyapkbv7z2bhfr9jv5hwywwabsq-virt-manager-1.5.0/share/virt-manager/virt-clone: interpreter directive changed from "/usr/bin/env python2" to "/nix/store/7b2z0vfbs9539ga4pxx5gmli47rz5y3n-python-2.7.14/bin/python2"
/nix/store/4clwsjyapkbv7z2bhfr9jv5hwywwabsq-virt-manager-1.5.0/share/virt-manager/virt-convert: interpreter directive changed from "/usr/bin/env python2" to "/nix/store/7b2z0vfbs9539ga4pxx5gmli47rz5y3n-python-2.7.14/bin/python2"
/nix/store/4clwsjyapkbv7z2bhfr9jv5hwywwabsq-virt-manager-1.5.0/share/virt-manager/virt-xml: interpreter directive changed from "/usr/bin/env python2" to "/nix/store/7b2z0vfbs9539ga4pxx5gmli47rz5y3n-python-2.7.14/bin/python2"
checking for references to /tmp/nix-build-virt-manager-1.5.0.drv-0 in /nix/store/4clwsjyapkbv7z2bhfr9jv5hwywwabsq-virt-manager-1.5.0...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/m32mh9dqn36i0zcyv3dlq7kwa56h8jkp-virt-manager-1.5.0/share/virt-manager/virt-install: interpreter directive changed from "/usr/bin/env python2" to "/nix/store/5crgsfgy8n7v50hrihx4mhxdqa01nrmw-python-2.7.14/bin/python2"
/nix/store/m32mh9dqn36i0zcyv3dlq7kwa56h8jkp-virt-manager-1.5.0/share/virt-manager/virt-manager: interpreter directive changed from "/usr/bin/env python2" to "/nix/store/5crgsfgy8n7v50hrihx4mhxdqa01nrmw-python-2.7.14/bin/python2"
/nix/store/m32mh9dqn36i0zcyv3dlq7kwa56h8jkp-virt-manager-1.5.0/share/virt-manager/virt-xml: interpreter directive changed from "/usr/bin/env python2" to "/nix/store/5crgsfgy8n7v50hrihx4mhxdqa01nrmw-python-2.7.14/bin/python2"
/nix/store/m32mh9dqn36i0zcyv3dlq7kwa56h8jkp-virt-manager-1.5.0/bin/.virt-xml-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/sh"
/nix/store/m32mh9dqn36i0zcyv3dlq7kwa56h8jkp-virt-manager-1.5.0/bin/.virt-manager-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/sh"
/nix/store/m32mh9dqn36i0zcyv3dlq7kwa56h8jkp-virt-manager-1.5.0/bin/.virt-install-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/sh"
/nix/store/m32mh9dqn36i0zcyv3dlq7kwa56h8jkp-virt-manager-1.5.0/bin/.virt-convert-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/sh"
/nix/store/m32mh9dqn36i0zcyv3dlq7kwa56h8jkp-virt-manager-1.5.0/bin/.virt-clone-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/m32mh9dqn36i0zcyv3dlq7kwa56h8jkp-virt-manager-1.5.0...
/nix/store/m32mh9dqn36i0zcyv3dlq7kwa56h8jkp-virt-manager-1.5.0

@Mic92 Mic92 merged commit aa6d6cc into NixOS:master Feb 23, 2018
@xeji xeji deleted the virtmanager-cleanup branch February 23, 2018 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants