New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
virtmanager: 1.4.3 -> 1.5.0, cleanup dependencies #35151
Conversation
remove unneeded dependencies, see issue NixOS#34043
otherwise virt-manager startup fails with Typelib file for namespace 'Pango', version '1.0' not found: Could not open display: :0
@GrahamcOfBorg eval |
@GrahamcOfBorg eval |
@GrahamcOfBorg build virtmanager |
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
The libvirt-glib dependency isn't new and explicitly required in virt-manager source. Don't think we can change that. |
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-linux (full log) Partial log (click to expand)
|
@xeji it is required for example here: https://github.com/virt-manager/virt-manager/blob/1302156265c9b340b48ea2c99b6079c7c92e8d76/virt-manager#L30 |
@jtojnar so should we exclude darwin in virtmanager for the time being? |
@xeji We could just ignore it for now. Though if you want, you could try changing the |
platforms: linux -> unix to see if it builds on Darwin
@GrahamcOfBorg build virtmanager |
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
@jtojnar this seems to be more complicated on Darwin. Let's reverse the last commit and set |
... but it doesn't (needs libcap-ng) This reverts commit 7795947.
since dependency libvirt-glib currently doesn't build on Darwin
@GrahamcOfBorg build virtmanager |
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Failure on x86_64-linux (full log) Partial log (click to expand)
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
@xeji hopefully resolved soon, when hydra catches up. |
@GrahamcOfBorg build virtmanager |
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
remove unneeded dependencies.
closes issue #34043
Motivation for this change
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)/cc maintainers: @qknight @offlinehacker @fpletz