Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt5X.full: add "-full" to package name #35107

Closed
wants to merge 1 commit into from
Closed

qt5X.full: add "-full" to package name #35107

wants to merge 1 commit into from

Conversation

bjornfor
Copy link
Contributor

Motivation for this change

This aligns store path name more with attrname.

This is a re-application of the idea behind 7405af7
("qt: make package names of "full" variants appear as such"), which
seems to have been lost on the way.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bjornfor
qt5X.full: add "-full" to package name
8b0eab1 
This aligns the package name more with the attrname.

This is a re-application of the idea behind 7405af7
("qt: make package names of "full" variants appear as such"), which
seems to have been lost on the way.
@bjornfor bjornfor changed the title qt5X.full: append "-full" to store path name qt5X.full: add "-full" to package name Feb 18, 2018
@bjornfor
Copy link
Contributor Author

Applied to master (09cf350).

@bjornfor bjornfor closed this Feb 18, 2018
@bjornfor bjornfor deleted the qt5full-add-full-to-name branch February 18, 2018 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bjornfor @GrahamcOfBorg