Skip to content

Commit

Permalink
redshift, liferea: remove the extra cache file
Browse files Browse the repository at this point in the history 
They're not really useful and cause collisions in envs.
  • Loading branch information
@vcunat
vcunat committed Feb 18, 2018
1 parent dca3146 commit 47f25fa
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
5 changes: 4 additions & 1 deletion pkgs/applications/misc/redshift/default.nix
View file
Expand Up @@ -41,7 +41,10 @@ stdenv.mkDerivation rec {
pythonPath = [ pygobject3 pyxdg ];

preConfigure = "./bootstrap";
postFixup = "wrapPythonPrograms";
postFixup = ''
wrapPythonPrograms
rm "$out/share/icons/hicolor/icon-theme.cache"
'';

enableParallelBuilding = true;

Expand Down
1 change: 1 addition & 0 deletions pkgs/applications/networking/newsreaders/liferea/default.nix
View file
Expand Up @@ -28,6 +28,7 @@ in stdenv.mkDerivation rec {
pythonPath = with python3Packages; [ pygobject3 pycairo ];

preFixup = ''
rm "$out/share/icons/hicolor/icon-theme.cache"
buildPythonPath "$out $pythonPath"
gappsWrapperArgs+=(--prefix PYTHONPATH : "$program_PYTHONPATH")
'';
Expand Down

3 comments on commit 47f25fa

@abbradar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW hicolor_icon_theme has a setup hook which does this automatically.

@vcunat
Copy link
Member Author

@vcunat vcunat commented on 47f25fa Feb 19, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I know, but it seemed strange to add dependency on the theme only to get the hook :-)

@abbradar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I checked the theme's setup hook and it seems it doesn't do much else useful -- it was a kneejerk autoreconfTool-like reaction ^_^"

Please sign in to comment.