Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker-credential-gcr: init at 1.4.3 #35117

Merged
merged 2 commits into from Feb 20, 2018
Merged

docker-credential-gcr: init at 1.4.3 #35117

merged 2 commits into from Feb 20, 2018

Conversation

suvash
Copy link
Contributor

@suvash suvash commented Feb 18, 2018 •
edited

Add a (Golang based) binary that provides authentication to Docker repositories hosted on Google Cloud Registry (GCR). This tool is required when using https://gcr.io based Docker repositories hosted on GCP, making use of various Google Oauth features to authenticate.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@suvash
docker-credential-gcr: init at 1.4.3
c7e01ac 
Docker authentication helper for Google Cloud (gcr.io) repositories
@suvash
Copy link
Contributor Author

suvash commented Feb 18, 2018 •
edited

Only installed NixOS over the weekend, and planning to get back to using it. Obviously, I've forgotten a lot of how it works. Let me know if there's anything missing/wrong with this package request.

nlewo
nlewo requested changes Feb 20, 2018
View reviewed changes
pkgs/tools/admin/docker-credential-gcr/default.nix Outdated
sha256 = "1xb88xjyyrdmjcgfv7fqdkv1ip3dpzsdif5vm7vkqvn83s5wj5df";
};

goDeps = ./deps.nix;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could remove it since it is empty

@suvash
Copy link
Contributor Author

suvash commented Feb 20, 2018

@nlewo Updated !

@nlewo
Copy link
Member

nlewo commented Feb 20, 2018

@GrahamcOfBorg build docker-credential-gcr

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/73717jiqg24iq6kgk49qfdzq9cligv5f-docker-credential-gcr-1.4.3-bin/bin/docker-credential-gcr
strip is /nix/store/skd6ix5ipkyhxzq7naylj4digawakl4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/73717jiqg24iq6kgk49qfdzq9cligv5f-docker-credential-gcr-1.4.3-bin/bin
patching script interpreter paths in /nix/store/73717jiqg24iq6kgk49qfdzq9cligv5f-docker-credential-gcr-1.4.3-bin
checking for references to /build in /nix/store/73717jiqg24iq6kgk49qfdzq9cligv5f-docker-credential-gcr-1.4.3-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/ykwhjd8pqix9k6agc4llfz0bfndnl80c-docker-credential-gcr-1.4.3
strip is /nix/store/skd6ix5ipkyhxzq7naylj4digawakl4j-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/ykwhjd8pqix9k6agc4llfz0bfndnl80c-docker-credential-gcr-1.4.3
checking for references to /build in /nix/store/ykwhjd8pqix9k6agc4llfz0bfndnl80c-docker-credential-gcr-1.4.3...
/nix/store/73717jiqg24iq6kgk49qfdzq9cligv5f-docker-credential-gcr-1.4.3-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/x6gbhs013kygifriqmpfy7fcnzn08sbl-docker-credential-gcr-1.4.3-bin/bin/docker-credential-gcr
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/x6gbhs013kygifriqmpfy7fcnzn08sbl-docker-credential-gcr-1.4.3-bin/bin 
patching script interpreter paths in /nix/store/x6gbhs013kygifriqmpfy7fcnzn08sbl-docker-credential-gcr-1.4.3-bin
checking for references to /tmp/nix-build-docker-credential-gcr-1.4.3.drv-0 in /nix/store/x6gbhs013kygifriqmpfy7fcnzn08sbl-docker-credential-gcr-1.4.3-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/w169xvaq8x60g7g1kw2l8awbn5ahnpcy-docker-credential-gcr-1.4.3
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/w169xvaq8x60g7g1kw2l8awbn5ahnpcy-docker-credential-gcr-1.4.3
checking for references to /tmp/nix-build-docker-credential-gcr-1.4.3.drv-0 in /nix/store/w169xvaq8x60g7g1kw2l8awbn5ahnpcy-docker-credential-gcr-1.4.3...
/nix/store/x6gbhs013kygifriqmpfy7fcnzn08sbl-docker-credential-gcr-1.4.3-bin

@nlewo nlewo merged commit 040fb6c into NixOS:master Feb 20, 2018
@nlewo
Copy link
Member

nlewo commented Feb 20, 2018

Thanks!

@suvash suvash deleted the add-docker-credential-gcr branch February 20, 2018 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo requested changes

Assignees
No one assigned
Labels
8.has: documentation 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@suvash @nlewo @GrahamcOfBorg