Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs: 6.12.3 -> 6.13.0 #35118

Merged
merged 1 commit into from Feb 21, 2018
Merged

nodejs: 6.12.3 -> 6.13.0 #35118

merged 1 commit into from Feb 21, 2018

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Feb 18, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc nodejs maintainers @goibhniu @Havvy @gilligan @cko

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

/nix/store/8zmq8grv270rnzhindfzvq2qnsd95yd7-nodejs-6.13.0/lib/node_modules/npm/node_modules/semver/bin/semver: interpreter directive changed from "/usr/bin/env node" to "/nix/store/8zmq8grv270rnzhindfzvq2qnsd95yd7-nodejs-6.13.0/bin/node"
/nix/store/8zmq8grv270rnzhindfzvq2qnsd95yd7-nodejs-6.13.0/lib/node_modules/npm/node_modules/which/bin/which: interpreter directive changed from "/usr/bin/env node" to "/nix/store/8zmq8grv270rnzhindfzvq2qnsd95yd7-nodejs-6.13.0/bin/node"
/nix/store/8zmq8grv270rnzhindfzvq2qnsd95yd7-nodejs-6.13.0/lib/node_modules/npm/scripts/index-build.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/8zmq8grv270rnzhindfzvq2qnsd95yd7-nodejs-6.13.0/bin/node"
/nix/store/8zmq8grv270rnzhindfzvq2qnsd95yd7-nodejs-6.13.0/lib/node_modules/npm/scripts/maketest: interpreter directive changed from "/usr/bin/env node" to "/nix/store/8zmq8grv270rnzhindfzvq2qnsd95yd7-nodejs-6.13.0/bin/node"
post-installation fixup
gzipping man pages under /nix/store/8zmq8grv270rnzhindfzvq2qnsd95yd7-nodejs-6.13.0/share/man/
strip is /nix/store/v8ifq0hapblpr2z0hx4wvwg02w4aczqy-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/8zmq8grv270rnzhindfzvq2qnsd95yd7-nodejs-6.13.0/lib  /nix/store/8zmq8grv270rnzhindfzvq2qnsd95yd7-nodejs-6.13.0/bin
patching script interpreter paths in /nix/store/8zmq8grv270rnzhindfzvq2qnsd95yd7-nodejs-6.13.0
/nix/store/8zmq8grv270rnzhindfzvq2qnsd95yd7-nodejs-6.13.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/k8yvf022p9hspp5lkrknjpnxpqda4mk5-nodejs-6.13.0/lib/node_modules/npm/cli.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/k8yvf022p9hspp5lkrknjpnxpqda4mk5-nodejs-6.13.0/bin/node"
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/k8yvf022p9hspp5lkrknjpnxpqda4mk5-nodejs-6.13.0
shrinking /nix/store/k8yvf022p9hspp5lkrknjpnxpqda4mk5-nodejs-6.13.0/bin/node
gzipping man pages under /nix/store/k8yvf022p9hspp5lkrknjpnxpqda4mk5-nodejs-6.13.0/share/man/
strip is /nix/store/skd6ix5ipkyhxzq7naylj4digawakl4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/k8yvf022p9hspp5lkrknjpnxpqda4mk5-nodejs-6.13.0/lib  /nix/store/k8yvf022p9hspp5lkrknjpnxpqda4mk5-nodejs-6.13.0/bin
patching script interpreter paths in /nix/store/k8yvf022p9hspp5lkrknjpnxpqda4mk5-nodejs-6.13.0
checking for references to /build in /nix/store/k8yvf022p9hspp5lkrknjpnxpqda4mk5-nodejs-6.13.0...
/nix/store/k8yvf022p9hspp5lkrknjpnxpqda4mk5-nodejs-6.13.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/wl0ljm3kb3wcxvxxmr6fab8nwycvn7cr-nodejs-6.13.0/lib/node_modules/npm/scripts/index-build.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/wl0ljm3kb3wcxvxxmr6fab8nwycvn7cr-nodejs-6.13.0/bin/node"
/nix/store/wl0ljm3kb3wcxvxxmr6fab8nwycvn7cr-nodejs-6.13.0/lib/node_modules/npm/scripts/maketest: interpreter directive changed from "/usr/bin/env node" to "/nix/store/wl0ljm3kb3wcxvxxmr6fab8nwycvn7cr-nodejs-6.13.0/bin/node"
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wl0ljm3kb3wcxvxxmr6fab8nwycvn7cr-nodejs-6.13.0
shrinking /nix/store/wl0ljm3kb3wcxvxxmr6fab8nwycvn7cr-nodejs-6.13.0/bin/node
gzipping man pages under /nix/store/wl0ljm3kb3wcxvxxmr6fab8nwycvn7cr-nodejs-6.13.0/share/man/
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/wl0ljm3kb3wcxvxxmr6fab8nwycvn7cr-nodejs-6.13.0/lib  /nix/store/wl0ljm3kb3wcxvxxmr6fab8nwycvn7cr-nodejs-6.13.0/bin
patching script interpreter paths in /nix/store/wl0ljm3kb3wcxvxxmr6fab8nwycvn7cr-nodejs-6.13.0
checking for references to /build in /nix/store/wl0ljm3kb3wcxvxxmr6fab8nwycvn7cr-nodejs-6.13.0...

@adisbladis adisbladis merged commit 44c4b70 into NixOS:master Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adisbladis @GrahamcOfBorg