Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker_compose : 1.18.0 -> 1.19.0 #35128

Merged
merged 1 commit into from Feb 21, 2018
Merged

docker_compose : 1.18.0 -> 1.19.0 #35128

merged 1 commit into from Feb 21, 2018

Conversation

suvash
Copy link
Contributor

@suvash suvash commented Feb 18, 2018 •
edited

Update Docker Compose to the latest version released. Various bugfixes and updates as specified at https://github.com/docker/compose/releases/tag/1.19.0

Tested locally and verify that bugs present in 1.18.0 (with some complex compose files) are fixed.

Use latest release with bugfixes and updates
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@suvash
docker_compose : 1.18.0 -> 1.19.0
f27ade6 
Update Docker Compose to the latest version released. Various bugfixes
and updates as specified at
https://github.com/docker/compose/releases/tag/1.19.0
@suvash suvash requested a review from FRidh as a code owner February 18, 2018 17:13
@nlewo
Copy link
Member

nlewo commented Feb 19, 2018 •
edited

@GrahamcOfBorg build docker_compose

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

Successfully installed docker-compose-1.19.0
/tmp/nix-build-docker-compose-1.19.0.drv-0/docker-compose-1.19.0
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rjhwymrz856wmkkwgcl50h0sjpg8ywwh-docker-compose-1.19.0
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/rjhwymrz856wmkkwgcl50h0sjpg8ywwh-docker-compose-1.19.0/lib  /nix/store/rjhwymrz856wmkkwgcl50h0sjpg8ywwh-docker-compose-1.19.0/bin 
patching script interpreter paths in /nix/store/rjhwymrz856wmkkwgcl50h0sjpg8ywwh-docker-compose-1.19.0
checking for references to /tmp/nix-build-docker-compose-1.19.0.drv-0 in /nix/store/rjhwymrz856wmkkwgcl50h0sjpg8ywwh-docker-compose-1.19.0...
wrapping `/nix/store/rjhwymrz856wmkkwgcl50h0sjpg8ywwh-docker-compose-1.19.0/bin/docker-compose'...
/nix/store/rjhwymrz856wmkkwgcl50h0sjpg8ywwh-docker-compose-1.19.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

Successfully installed docker-compose-1.19.0
/build/docker-compose-1.19.0
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/gd458kzm1v22jy58ijcr1m0jv9im9q6r-docker-compose-1.19.0
strip is /nix/store/skd6ix5ipkyhxzq7naylj4digawakl4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/gd458kzm1v22jy58ijcr1m0jv9im9q6r-docker-compose-1.19.0/lib  /nix/store/gd458kzm1v22jy58ijcr1m0jv9im9q6r-docker-compose-1.19.0/bin
patching script interpreter paths in /nix/store/gd458kzm1v22jy58ijcr1m0jv9im9q6r-docker-compose-1.19.0
checking for references to /build in /nix/store/gd458kzm1v22jy58ijcr1m0jv9im9q6r-docker-compose-1.19.0...
wrapping `/nix/store/gd458kzm1v22jy58ijcr1m0jv9im9q6r-docker-compose-1.19.0/bin/docker-compose'...
/nix/store/gd458kzm1v22jy58ijcr1m0jv9im9q6r-docker-compose-1.19.0

@Mic92 Mic92 merged commit e2a7975 into NixOS:master Feb 21, 2018
@suvash suvash deleted the update-docker-compose branch February 21, 2018 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@suvash @nlewo @GrahamcOfBorg @Mic92