Unify scalar multiplications and divisions of R3Elements and Multivectors #1727
Conversation
quantities/quantities.hpp
Outdated
| template<typename D> | ||
| struct is_quantity<Quantity<D>> : std::true_type, not_constructible {}; | ||
| template<> | ||
| __m128d ToM128D(int x); |
There was a problem hiding this comment.
Declare two templatized overloads, one for arbitrary types (with an is_arithmetic static_assert) and one for quantities.
Since the Quantity one actually takes a Quantity (and not Wide<Quantity> or something like that when that appears, or at least will have a separate overload for that), there will be no need for SFINAE tricks here.
| operator*(Quantity<LDimension> const& left, | ||
| template<typename LScalar, typename RScalar, typename Frame, int rank, | ||
| typename = std::enable_if_t<is_quantity<LScalar>::value>> | ||
| Multivector<Product<LScalar, RScalar>, Frame, rank> |
There was a problem hiding this comment.
Note that if you want this to work with wide quantities, a Quantity operator*(Wide<Quantity>, Quantity) has to be declared.
This is OK: we can declare the operators, which allows their usage in a decltype, and put a failing dependent static_assert in their definition to prevent them from being used, e.g., https://godbolt.org/g/DbUP24.
It makes things easier to understand and gives us good diagnostics, so this is probably the way to go.
No description provided.