Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart: 1.16.1 -> 1.24.3 #35104

Merged
merged 1 commit into from Feb 20, 2018
Merged

dart: 1.16.1 -> 1.24.3 #35104

merged 1 commit into from Feb 20, 2018

Conversation

izuk
Copy link
Contributor

@izuk izuk commented Feb 18, 2018

Also, added support for the "dev" channel.

Motivation for this change

Trying to get flutter packaged, and it needs a particular version of dart (maybe?).

Also, just upgrading dart.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

joachifm
joachifm reviewed Feb 18, 2018
View reviewed changes
pkgs/development/interpreters/dart/default.nix Outdated
sha256 = "0jfwzc3jbk4n5j9ka59s9bkb25l5g85fl1nf676mvj36swcfykx3";
};

src = sources."${version}-${stdenv.system}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc, using or (throw "unsupported system: ${stdenv.system}") here would be nicer than raw lookup error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@joachifm
Copy link
Contributor

@GrahamcOfBorg build dart

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘dart-1.24.3’ in /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/development/interpreters/dart/default.nix:65 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/c6wzik353cj0n6kcccgvih7qqmvyi33q-dart-1.24.3/bin/dartdevc: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/bash"
/nix/store/c6wzik353cj0n6kcccgvih7qqmvyi33q-dart-1.24.3/bin/pub: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/bash"
/nix/store/c6wzik353cj0n6kcccgvih7qqmvyi33q-dart-1.24.3/bin/dart2js: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/bash"
/nix/store/c6wzik353cj0n6kcccgvih7qqmvyi33q-dart-1.24.3/bin/dartfmt: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/bash"
/nix/store/c6wzik353cj0n6kcccgvih7qqmvyi33q-dart-1.24.3/bin/dartanalyzer: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/bash"
/nix/store/c6wzik353cj0n6kcccgvih7qqmvyi33q-dart-1.24.3/lib/analysis_server/tool/spec/generate_files: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/bash"
/nix/store/c6wzik353cj0n6kcccgvih7qqmvyi33q-dart-1.24.3/lib/analyzer/tool/generate_files: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/bash"
/nix/store/c6wzik353cj0n6kcccgvih7qqmvyi33q-dart-1.24.3/lib/front_end/tool/fasta: interpreter directive changed from "/bin/bash" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-dart-1.24.3.drv-0 in /nix/store/c6wzik353cj0n6kcccgvih7qqmvyi33q-dart-1.24.3...
/nix/store/c6wzik353cj0n6kcccgvih7qqmvyi33q-dart-1.24.3

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘dart-1.24.3’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/interpreters/dart/default.nix:65 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@izuk
dart: 1.16.1 -> 1.24.3
3efb969 
Also, added support for the "dev" channel.
@joachifm joachifm merged commit 1aa3777 into NixOS:master Feb 20, 2018
@izuk izuk deleted the dart branch February 25, 2018 16:05
@aanderse
Copy link
Member

aanderse commented Jul 4, 2019

@izuk Did you end up packaging flutter?

@izuk
Copy link
Contributor Author

izuk commented Jul 5, 2019 via email

@aanderse
Copy link
Member

aanderse commented Jul 6, 2019

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@izuk @joachifm @GrahamcOfBorg @aanderse