Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catdocx: init at 20170102 #35105

Merged
merged 1 commit into from Feb 18, 2018
Merged

catdocx: init at 20170102 #35105

merged 1 commit into from Feb 18, 2018

Conversation

michalrus
Copy link
Member

Motivation for this change

catdoc is great, but it can’t do *.docxes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Has no version, but upstream has no version either.

@7c6f434c
Copy link
Member

Please provide a date-based version to make future updates visible. In case it is likely that 0.1 will even exist, you might consider (I don't insist, though) 0.1-pre-2018.02.18 (or whatever the date of latest commit), otherwise just a date would work fine.

@michalrus michalrus changed the title catdocx: init catdocx: init at 20170102 Feb 18, 2018
@michalrus
Copy link
Member Author

Absolutely! Sorry I didn’t think of that. =)

Fixed!

@7c6f434c 7c6f434c merged commit 57062da into NixOS:master Feb 18, 2018
@michalrus michalrus deleted the catdocx branch February 18, 2018 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: documentation 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michalrus @7c6f434c @GrahamcOfBorg