Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mackup: init at 0.8.16 #35163

Closed
wants to merge 1 commit into from
Closed

mackup: init at 0.8.16 #35163

wants to merge 1 commit into from

Conversation

josh1703658784
Copy link

Motivation for this change

New application mackup for handling dot files.

Things done

- [ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS) (I think this is broken on darwin at the moment)

  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

python2Packages.buildPythonApplication rec {
name = "mackup-0.8.16";

src = fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchPypi

sha256 = "0f5cb5srxa3bn7lbfs5rb4iqjs57blzvgypivndy756vsvm9ijrv";
};

"docopt" = python2Packages.buildPythonPackage {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this in pkgs/development/python-modules and use callPackage in python-packages.nix.

"docopt" = python2Packages.buildPythonPackage {
name = "docopt-0.6.2";
doCheck = false;
src = fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchPypi


"docopt" = python2Packages.buildPythonPackage {
name = "docopt-0.6.2";
doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

};

"docopt" = python2Packages.buildPythonPackage {
name = "docopt-0.6.2";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pname and version instead

}:

python2Packages.buildPythonApplication rec {
name = "mackup-0.8.16";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pname and version instead

{ lib
, fetchurl
, python2Packages
, stdenv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stdenv not needed, use lib

@@ -3431,6 +3431,8 @@ with pkgs;

macchanger = callPackage ../os-specific/linux/macchanger { };

mackup = callPackage ../tools/backup/mackup { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use python2Packages.callPackage and specify the dependencies as arguments instead of python2Packages.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the feedback. I'll try to get to this in the next day or two.

@jtojnar
Copy link
Contributor

jtojnar commented Oct 21, 2018

Any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants