Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watchexec: init at 1.8.6 #35103

Merged
merged 1 commit into from Feb 20, 2018
Merged

watchexec: init at 1.8.6 #35103

merged 1 commit into from Feb 20, 2018

Conversation

michalrus
Copy link
Member

Motivation for this change

One of the few tools of this sort that actually work reliably.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

@GrahamcOfBorg build watchexec

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

          clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)


error: aborting due to previous error

error: Could not compile `watchexec`.

To learn more, run the command again with --verbose.
builder for '/nix/store/ldk16hrj8lyi732w82vhawzd41bfd60c-watchexec-1.8.6.drv' failed with exit code 101
error: build of '/nix/store/ldk16hrj8lyi732w82vhawzd41bfd60c-watchexec-1.8.6.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/examples'
cp: -r not specified; omitting directory 'target/release/build'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lgq5l03f5zjsd53pjil7pmip8ff2z5b5-watchexec-1.8.6
shrinking /nix/store/lgq5l03f5zjsd53pjil7pmip8ff2z5b5-watchexec-1.8.6/bin/watchexec
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/lgq5l03f5zjsd53pjil7pmip8ff2z5b5-watchexec-1.8.6/bin
patching script interpreter paths in /nix/store/lgq5l03f5zjsd53pjil7pmip8ff2z5b5-watchexec-1.8.6
checking for references to /build in /nix/store/lgq5l03f5zjsd53pjil7pmip8ff2z5b5-watchexec-1.8.6...
/nix/store/lgq5l03f5zjsd53pjil7pmip8ff2z5b5-watchexec-1.8.6

@michalrus
Copy link
Member Author

michalrus commented Feb 18, 2018

  = note: ld: framework not found CoreServices
          clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)

Emmm. How do I add those?

Like that, I think. =)

    ++ lib.optionals stdenv.isDarwin [ CoreServices ];

@michalrus
Copy link
Member Author

Fixed, hopefully.

@michalrus
Copy link
Member Author

@GrahamcOfBorg build watchexec

1 similar comment
@joachifm
Copy link
Contributor

@GrahamcOfBorg build watchexec

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

          clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)


error: aborting due to previous error

error: Could not compile `watchexec`.

To learn more, run the command again with --verbose.
builder for '/nix/store/ylfms88alkml3iigmf45gjhl1wmnz1k2-watchexec-1.8.6.drv' failed with exit code 101
error: build of '/nix/store/ylfms88alkml3iigmf45gjhl1wmnz1k2-watchexec-1.8.6.drv' failed

@joachifm
Copy link
Contributor

Maybe just leave darwin unsupported for now; testing via bot invocation is a little tedious :)

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/native'
cp: -r not specified; omitting directory 'target/release/examples'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lgq5l03f5zjsd53pjil7pmip8ff2z5b5-watchexec-1.8.6
shrinking /nix/store/lgq5l03f5zjsd53pjil7pmip8ff2z5b5-watchexec-1.8.6/bin/watchexec
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/lgq5l03f5zjsd53pjil7pmip8ff2z5b5-watchexec-1.8.6/bin 
patching script interpreter paths in /nix/store/lgq5l03f5zjsd53pjil7pmip8ff2z5b5-watchexec-1.8.6
checking for references to /tmp/nix-build-watchexec-1.8.6.drv-0 in /nix/store/lgq5l03f5zjsd53pjil7pmip8ff2z5b5-watchexec-1.8.6...
/nix/store/lgq5l03f5zjsd53pjil7pmip8ff2z5b5-watchexec-1.8.6

@michalrus
Copy link
Member Author

michalrus commented Feb 18, 2018

@joachifm, OK, let’s try it one last time, please, and if it doesn’t work now, I’ll stick to platforms.linux. =) This tool shouldn’t have many complicated deps. A pity they don’t list them upstream.

@joachifm
Copy link
Contributor

@GrahamcOfBorg build watchexec

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/lgq5l03f5zjsd53pjil7pmip8ff2z5b5-watchexec-1.8.6

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

          clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)


error: aborting due to previous error

error: Could not compile `watchexec`.

To learn more, run the command again with --verbose.
builder for '/nix/store/dn780fnvs1rzscgz1ra2mpnk7pxmya2a-watchexec-1.8.6.drv' failed with exit code 101
error: build of '/nix/store/dn780fnvs1rzscgz1ra2mpnk7pxmya2a-watchexec-1.8.6.drv' failed

@michalrus
Copy link
Member Author

Huh, from quick Google™’ing, that _CFURLResourceIsReachable symbol is defined in CoreFoundation. ¯\_(ツ)_/¯

I dunno then. Removing darwin.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

cannot build derivation '/nix/store/apsv8rlmpvgizr0f06csflhc7y4yhmdv-rust_serde_derive-1.0.18.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/8mipp70kwp7bkxiz6ylyxlqsfqxlb6pk-rust_crates-io-0.11.0.drv': 30 dependencies couldn't be built
cannot build derivation '/nix/store/7shhd7gnznc9knnhvz74mz3kr3wjjwsy-rust_docopt-0.8.1.drv': 19 dependencies couldn't be built
cannot build derivation '/nix/store/1jgbhra3z2hibkkdmwnli3fqr8s028m8-rust_git2-curl-0.7.0.drv': 20 dependencies couldn't be built
cannot build derivation '/nix/store/prckgsm3fhb9i11vg7x20qg964rg269r-rust_ignore-0.2.2.drv': 18 dependencies couldn't be built
cannot build derivation '/nix/store/5d4qsbv8545svcay45v4zzdji2b2f4w5-rust_cargo-0.22.0.drv': 78 dependencies couldn't be built
cannot build derivation '/nix/store/sv5cq2948fpj304v63h8ykd8v21j4l1d-rust_cargo-vendor-0.1.13.drv': 79 dependencies couldn't be built
cannot build derivation '/nix/store/ydfy23hqwx0mn7cvhfj2zximn21106hl-watchexec-1.8.6-vendor.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/4bl3j0g4nqa61xb57mh97kz68w6cm71l-watchexec-1.8.6.drv': 3 dependencies couldn't be built
error: build of '/nix/store/4bl3j0g4nqa61xb57mh97kz68w6cm71l-watchexec-1.8.6.drv' failed

@michalrus
Copy link
Member Author

building of '/nix/store/r36md20sbgcvcnrv0qx4s9ck44kll2nr-rustc-1.22.1.drv' timed out after 3600 seconds

Hmmmm. It worked just a while ago. ;o

@michalrus
Copy link
Member Author

@GrahamcOfBorg build watchexec

@michalrus
Copy link
Member Author

Ohhhhh, arm64.

@joachifm
Copy link
Contributor

Note that you need to register to use the bot :)

@michalrus
Copy link
Member Author

A PR to https://github.com/NixOS/ofborg/blob/released/config.known-users.json? Probably not worth it for an occasional PR. Would you suggest I do this?

@joachifm
Copy link
Contributor

A committer should be able to invoke the bot for you in most cases so it's not strictly necessary.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

cannot build derivation '/nix/store/apsv8rlmpvgizr0f06csflhc7y4yhmdv-rust_serde_derive-1.0.18.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/8mipp70kwp7bkxiz6ylyxlqsfqxlb6pk-rust_crates-io-0.11.0.drv': 30 dependencies couldn't be built
cannot build derivation '/nix/store/7shhd7gnznc9knnhvz74mz3kr3wjjwsy-rust_docopt-0.8.1.drv': 19 dependencies couldn't be built
cannot build derivation '/nix/store/1jgbhra3z2hibkkdmwnli3fqr8s028m8-rust_git2-curl-0.7.0.drv': 20 dependencies couldn't be built
cannot build derivation '/nix/store/prckgsm3fhb9i11vg7x20qg964rg269r-rust_ignore-0.2.2.drv': 18 dependencies couldn't be built
cannot build derivation '/nix/store/5d4qsbv8545svcay45v4zzdji2b2f4w5-rust_cargo-0.22.0.drv': 78 dependencies couldn't be built
cannot build derivation '/nix/store/sv5cq2948fpj304v63h8ykd8v21j4l1d-rust_cargo-vendor-0.1.13.drv': 79 dependencies couldn't be built
cannot build derivation '/nix/store/ydfy23hqwx0mn7cvhfj2zximn21106hl-watchexec-1.8.6-vendor.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/4bl3j0g4nqa61xb57mh97kz68w6cm71l-watchexec-1.8.6.drv': 3 dependencies couldn't be built
error: build of '/nix/store/4bl3j0g4nqa61xb57mh97kz68w6cm71l-watchexec-1.8.6.drv' failed

@michalrus
Copy link
Member Author

michalrus commented Feb 18, 2018

I’m not entirely sure why it tries to build it on arm64, if I explicitly stated:

+    platforms = [ "x86_64-linux" ];

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

cannot build derivation '/nix/store/apsv8rlmpvgizr0f06csflhc7y4yhmdv-rust_serde_derive-1.0.18.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/8mipp70kwp7bkxiz6ylyxlqsfqxlb6pk-rust_crates-io-0.11.0.drv': 30 dependencies couldn't be built
cannot build derivation '/nix/store/7shhd7gnznc9knnhvz74mz3kr3wjjwsy-rust_docopt-0.8.1.drv': 19 dependencies couldn't be built
cannot build derivation '/nix/store/1jgbhra3z2hibkkdmwnli3fqr8s028m8-rust_git2-curl-0.7.0.drv': 20 dependencies couldn't be built
cannot build derivation '/nix/store/prckgsm3fhb9i11vg7x20qg964rg269r-rust_ignore-0.2.2.drv': 18 dependencies couldn't be built
cannot build derivation '/nix/store/5d4qsbv8545svcay45v4zzdji2b2f4w5-rust_cargo-0.22.0.drv': 78 dependencies couldn't be built
cannot build derivation '/nix/store/sv5cq2948fpj304v63h8ykd8v21j4l1d-rust_cargo-vendor-0.1.13.drv': 79 dependencies couldn't be built
cannot build derivation '/nix/store/ydfy23hqwx0mn7cvhfj2zximn21106hl-watchexec-1.8.6-vendor.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/4bl3j0g4nqa61xb57mh97kz68w6cm71l-watchexec-1.8.6.drv': 3 dependencies couldn't be built
error: build of '/nix/store/4bl3j0g4nqa61xb57mh97kz68w6cm71l-watchexec-1.8.6.drv' failed

@joachifm joachifm merged commit 9095f02 into NixOS:master Feb 20, 2018
@michalrus michalrus deleted the watchexec branch February 20, 2018 14:37
@michalrus
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants