Skip to content

Commit

Permalink
ntopng: fixup build with gcc7
Browse files Browse the repository at this point in the history 
... but the new gcc pointed out some real bug.  I suppose update
would be best: https://github.com/ntop/ntopng/releases
  • Loading branch information
@vcunat
vcunat committed Feb 18, 2018
1 parent 0a52c59 commit bf25148
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pkgs/tools/networking/ntopng/default.nix
View file
Expand Up @@ -53,6 +53,8 @@ stdenv.mkDerivation rec {
sed 's|LIBS += -lstdc++.6||' -i Makefile
'';

NIX_CFLAGS_COMPILE = [ "-fpermissive" ];

meta = with stdenv.lib; {
description = "High-speed web-based traffic analysis and flow collection tool";
homepage = http://www.ntop.org/products/ntop/;
Expand Down

5 comments on commit bf25148

@vcunat
Copy link
Member Author

@vcunat vcunat commented on bf25148 Feb 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc maintainer @bjornfor. I don't dare doing larger updates here.

@bjornfor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the build breakage. I'm not an active ntopng user, so don't restrain yourself because of me.

@vcunat
Copy link
Member Author

@vcunat vcunat commented on bf25148 Feb 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have never used it.

@bjornfor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a look.

@bjornfor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yak shaving.

  1. ntopng factored out one of its dependencies, nDPI, so it's no longer automatically built when building ntopng. We have nDPI already in nixpkgs, but ntopng build system insists on the source directory being located next to it, so it can built it itself. (ntopng development branch improves this by using pkg-config to find nDPI, but this has yet to be released.)
  2. Our nDPI is too old. Easy enough to update 1.8 -> 2.2.
  3. ntopng now requires MySQL/MariaDB. If ntopng doesn't find it, it will not generate a Makefile. (There is no error or configure check abort, it just skips creating the Makefile.) However, nixpkgs mariadb .pc file is borked, pointing to a non-existing includedir. This nixpkgs bug goes back to release-16.03 branch.
  4. ntopng now requires lj_obj.h, a header file found in luajit. This header isn't installed by default (neither in Ubuntu). I think users are not supposed to use lj_obj.h, but ntopng does (Build with external luajit no longer possible, due to lj_obj.h? ntop/ntopng#1664). Solution: use the bundled luajit tree from ntopng, at the expense of longer build times.
  5. Profit?

Please sign in to comment.