Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hydra: fix build with gcc7, incl. libpqxx update #35125

Merged
merged 1 commit into from Mar 4, 2018

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Feb 18, 2018

It builds, but it's otherwise untested.

I'm only concerned about the libpqxx update: it fixes the language issues rejected by gcc7, but it's a larger update, so there's some chance there was a semantic change that didn't break the build. Therefore I'm not merging this until it gets some testing or someone knowing the Hydra's source verifies it's OK. /cc maintainer @edolstra.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘darcs-2.12.5’ in /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/development/haskell-modules/hackage-packages.nix:55257 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘hydra-2017-11-21’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/build-support/release/nix-build.nix:151 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/kc1syk4pg656038lbaij2cs77pmnind1-hydra-2017-11-21
shrinking /nix/store/kc1syk4pg656038lbaij2cs77pmnind1-hydra-2017-11-21/bin/hydra-evaluator
shrinking /nix/store/kc1syk4pg656038lbaij2cs77pmnind1-hydra-2017-11-21/bin/hydra-eval-jobs
shrinking /nix/store/kc1syk4pg656038lbaij2cs77pmnind1-hydra-2017-11-21/bin/hydra-queue-runner
patching script interpreter paths in /nix/store/kc1syk4pg656038lbaij2cs77pmnind1-hydra-2017-11-21
checking for references to /build in /nix/store/kc1syk4pg656038lbaij2cs77pmnind1-hydra-2017-11-21...
finalPhase
build time elapsed:  0m0.494s 0m0.397s 1m17.650s 0m7.217s

@vcunat vcunat mentioned this pull request Feb 18, 2018
@vcunat vcunat closed this Feb 20, 2018
@vcunat vcunat changed the base branch from gcc-7 to staging February 20, 2018 19:41
@vcunat vcunat reopened this Feb 20, 2018
@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘hydra-2017-11-21’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/build-support/release/nix-build.nix:151 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘darcs-2.12.5’ in /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/development/haskell-modules/hackage-packages.nix:55308 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

cannot build derivation ‘/nix/store/lpby0y9rq47dmnlgrza7mwqdnr5wivw5-cryptonite-0.24.drv’: 4 dependencies couldn't be built
cannot build derivation ‘/nix/store/znl5vi8jfvvhvldjpm49qhksx543xnfs-graphviz-2999.19.0.0.drv’: 12 dependencies couldn't be built
cannot build derivation ‘/nix/store/i2vxpachhildwqagfn2a1dd1a7z509n4-sandi-0.4.1.drv’: 10 dependencies couldn't be built
cannot build derivation ‘/nix/store/sxf37zkj5ah736gl69ddmfcxfsmdnwdp-scientific-0.3.5.2.drv’: 13 dependencies couldn't be built
cannot build derivation ‘/nix/store/knxnf090yanryq2h9j6ry4bqk85aifc5-zip-archive-0.3.2.2.drv’: 9 dependencies couldn't be built
cannot build derivation ‘/nix/store/dsflvx7yy62kx619babssblrya6mh5a3-attoparsec-0.13.2.2.drv’: 4 dependencies couldn't be built
cannot build derivation ‘/nix/store/czvsk0zjh20nhb31nqwxwm2ymmh371zm-cryptohash-0.11.9.drv’: 10 dependencies couldn't be built
cannot build derivation ‘/nix/store/1xgdk2bxaaj13nhillimqsrwsja91mpx-darcs-2.12.5.drv’: 29 dependencies couldn't be built
cannot build derivation ‘/nix/store/478hasq84pqlc5n4brc6ypzb3p61czgw-hydra-2017-11-21.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/478hasq84pqlc5n4brc6ypzb3p61czgw-hydra-2017-11-21.drv’ failed

@dtzWill
Copy link
Member

dtzWill commented Feb 22, 2018

Found myself needing this in my setup, seeing errors like this:

/nix/store/r8zhwq9xylxw8a823kpvqy0kfqq4g52f-nix-2.0pre5968_a6c0b773/lib/libnixstore.so: undefined reference to `__cxa_init_primary_exception@CXXABI_1.3.11'
/nix/store/r8zhwq9xylxw8a823kpvqy0kfqq4g52f-nix-2.0pre5968_a6c0b773/lib/libnixstore.so: undefined reference to `std::__exception_ptr::exception_ptr::exception_ptr(void*)@CXXABI_1.3.11'

Since hydra's release.nix has it building with gcc6, but nix was built w/gcc7 (according to this those are symbol versions corresponding to 7.1, 7.2 and 8.0 -- presumably 7.3.0 as well).

I can't vet libpqxx's changelog but I'll give this a whirl and let you know if anything explodes :).

src = fetchFromGitHub {
owner = "edolstra";
repo = "aws-sdk-cpp";
rev = "local";
sha256 = "1vhgsxkhpai9a7dk38q4r239l6dsz2jvl8hii24c194lsga3g84h";
};
patches = attrs.patches or [] ++ [ ./aws-sdk-cpp-gcc7.patch ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to apply this patch in the aws-sdk-cpp expression?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It's a different source and doesn't need it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be better not to use yet another version of the package, but there was probably a good reason for that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's no longer needed. In fact Hydra doesn't need aws-sdk-cpp at all anymore (NixOS/hydra@3ec73c9).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the PR to remove it. I didn't realize AWS is now handled only by nix directly.

It builds, but it's otherwise untested.
@vcunat vcunat changed the base branch from staging to master February 23, 2018 16:09
@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘hydra-2017-11-21’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/build-support/release/nix-build.nix:151 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘darcs-2.12.5’ in /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/development/haskell-modules/hackage-packages.nix:55308 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/s11a0jjg83zwypyja7ha5h2d6j25y1p6-hydra-2017-11-21
shrinking /nix/store/s11a0jjg83zwypyja7ha5h2d6j25y1p6-hydra-2017-11-21/bin/hydra-queue-runner
shrinking /nix/store/s11a0jjg83zwypyja7ha5h2d6j25y1p6-hydra-2017-11-21/bin/hydra-evaluator
shrinking /nix/store/s11a0jjg83zwypyja7ha5h2d6j25y1p6-hydra-2017-11-21/bin/hydra-eval-jobs
patching script interpreter paths in /nix/store/s11a0jjg83zwypyja7ha5h2d6j25y1p6-hydra-2017-11-21
checking for references to /tmp/nix-build-hydra-2017-11-21.drv-0 in /nix/store/s11a0jjg83zwypyja7ha5h2d6j25y1p6-hydra-2017-11-21...
finalPhase
build time elapsed:  0m1.231s 0m1.008s 1m49.244s 0m17.441s
/nix/store/s11a0jjg83zwypyja7ha5h2d6j25y1p6-hydra-2017-11-21

@vcunat vcunat added this to the 18.03 milestone Feb 26, 2018
@fpletz fpletz merged commit 5668ca8 into NixOS:master Mar 4, 2018
@vcunat vcunat deleted the p/hydra-gcc7 branch March 4, 2018 09:32
@vcunat vcunat restored the p/hydra-gcc7 branch March 7, 2018 12:29
@vcunat vcunat deleted the p/hydra-gcc7 branch June 21, 2018 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants