New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hydra: fix build with gcc7, incl. libpqxx update #35125
Conversation
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-linux (full log) Partial log (click to expand)
|
Found myself needing this in my setup, seeing errors like this:
Since hydra's release.nix has it building with gcc6, but nix was built w/gcc7 (according to this those are symbol versions corresponding to 7.1, 7.2 and 8.0 -- presumably 7.3.0 as well). I can't vet libpqxx's changelog but I'll give this a whirl and let you know if anything explodes :). |
src = fetchFromGitHub { | ||
owner = "edolstra"; | ||
repo = "aws-sdk-cpp"; | ||
rev = "local"; | ||
sha256 = "1vhgsxkhpai9a7dk38q4r239l6dsz2jvl8hii24c194lsga3g84h"; | ||
}; | ||
patches = attrs.patches or [] ++ [ ./aws-sdk-cpp-gcc7.patch ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be better to apply this patch in the aws-sdk-cpp
expression?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. It's a different source and doesn't need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be better not to use yet another version of the package, but there was probably a good reason for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's no longer needed. In fact Hydra doesn't need aws-sdk-cpp at all anymore (NixOS/hydra@3ec73c9).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the PR to remove it. I didn't realize AWS is now handled only by nix directly.
It builds, but it's otherwise untested.
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
It builds, but it's otherwise untested.
I'm only concerned about the libpqxx update: it fixes the language issues rejected by gcc7, but it's a larger update, so there's some chance there was a semantic change that didn't break the build. Therefore I'm not merging this until it gets some testing or someone knowing the Hydra's source verifies it's OK. /cc maintainer @edolstra.