Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes broken references to javadoc #666

Merged
merged 5 commits into from Apr 15, 2018
Merged

Fixes broken references to javadoc #666

merged 5 commits into from Apr 15, 2018

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Feb 18, 2018 •
edited

Addresses the bottom two sections (Outdated references of #640 (comment))

This does not fix any outdated method references or imports that are no longer present in API 7.

Ready for review.

@Spongy
Copy link

Spongy commented Feb 18, 2018 •
edited

A preview for this pull request is available at https://cdn.rawgit.com/Spongy/SpongeDocs-PRs/edaa741/.

Here are some links to the pages that were modified:

Since the preview frequently changes, please link to this comment, not to the direct url to the preview.

@ST-DDT ST-DDT added needs review The submission is ready and needs to be reviewed outdated docs The API has changed and the docs are outdated low priority Small issues like typos that don't have much of an impact labels Feb 18, 2018
@Inscrutable Inscrutable removed the low priority Small issues like typos that don't have much of an impact label Mar 18, 2018
@Inscrutable Inscrutable requested review from phit and removed request for ZephireNZ, 12awsomeman34 and RobertHerhold April 15, 2018 14:35
@Inscrutable
Copy link
Member

Just one minor conflict to sort out and it's ready to rock @ST-DDT - feel free to throw the lever when you're done.

@ST-DDT
Merge remote-tracking branch 'origin/stable' into fixes/imports
bb5dfba 
Conflicts:
	source/plugin/blocks/modifying.rst
@ST-DDT ST-DDT merged commit 93f8c86 into stable Apr 15, 2018
@ST-DDT ST-DDT deleted the fixes/imports branch April 15, 2018 20:23
@ST-DDT ST-DDT mentioned this pull request Aug 26, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phit phit phit approved these changes

Assignees
No one assigned
Labels
needs review The submission is ready and needs to be reviewed outdated docs The API has changed and the docs are outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ST-DDT @Spongy @Inscrutable @phit