Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radare2: 2.2.0 -> 2.3.0 #35146

Merged
merged 2 commits into from Feb 19, 2018
Merged

radare2: 2.2.0 -> 2.3.0 #35146

merged 2 commits into from Feb 19, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 18, 2018

Bump radare2.

Also, bump to pinned capstone revision instead
of the capstone release (3.0.4) from 2015.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘radare2-2.3.0’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/tools/analysis/radare2/default.nix:50 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/qmijcmga7ilswwx6apdd6qvnp044f6bk-radare2-2.3.0/bin/ragg2
shrinking /nix/store/qmijcmga7ilswwx6apdd6qvnp044f6bk-radare2-2.3.0/bin/r2agent
gzipping man pages under /nix/store/qmijcmga7ilswwx6apdd6qvnp044f6bk-radare2-2.3.0/share/man/
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/qmijcmga7ilswwx6apdd6qvnp044f6bk-radare2-2.3.0/lib  /nix/store/qmijcmga7ilswwx6apdd6qvnp044f6bk-radare2-2.3.0/bin
patching script interpreter paths in /nix/store/qmijcmga7ilswwx6apdd6qvnp044f6bk-radare2-2.3.0
/nix/store/qmijcmga7ilswwx6apdd6qvnp044f6bk-radare2-2.3.0/bin/r2pm: interpreter directive changed from "/bin/sh" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/sh"
/nix/store/qmijcmga7ilswwx6apdd6qvnp044f6bk-radare2-2.3.0/bin/ragg2-cc: interpreter directive changed from "/bin/sh" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/qmijcmga7ilswwx6apdd6qvnp044f6bk-radare2-2.3.0...
/nix/store/qmijcmga7ilswwx6apdd6qvnp044f6bk-radare2-2.3.0

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

checking for libmagic ... no
Using PKGCONFIG: pkg-config
checking pkg-config flags for capstone... no
checking for libz ... yes
checking for libzip ... no
checking for libssl ... yes
checking pkg-config flags for openssl... yes
./configure: line 524: syntax error: support for $((arith)) is disabled
builder for '/nix/store/cwcbgagi9gs6k2idkh5mnzabib9gimla-radare2-2.3.0.drv' failed with exit code 2
error: build of '/nix/store/cwcbgagi9gs6k2idkh5mnzabib9gimla-radare2-2.3.0.drv' failed

@dtzWill
Copy link
Member Author

dtzWill commented Feb 18, 2018 •
edited

aarch64 failure is the "/bin/sh" problem, lack of arith expr support. Don't know if it worked previously, but at least this particular failure should be resolved by fixing/updating that.

(cc NixOS/aarch64-build-box#17)

@dtzWill
Copy link
Member Author

dtzWill commented Feb 19, 2018

@GrahamcOfBorg build radare2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/qmijcmga7ilswwx6apdd6qvnp044f6bk-radare2-2.3.0

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘radare2-2.3.0’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/tools/analysis/radare2/default.nix:50 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/1y7iabf6arzj607krb4i6k7sysprgy4z-radare2-2.3.0/lib/libr_asm.so.2.3.0
shrinking /nix/store/1y7iabf6arzj607krb4i6k7sysprgy4z-radare2-2.3.0/lib/libr_anal.so.2.3.0
gzipping man pages under /nix/store/1y7iabf6arzj607krb4i6k7sysprgy4z-radare2-2.3.0/share/man/
strip is /nix/store/skd6ix5ipkyhxzq7naylj4digawakl4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/1y7iabf6arzj607krb4i6k7sysprgy4z-radare2-2.3.0/lib  /nix/store/1y7iabf6arzj607krb4i6k7sysprgy4z-radare2-2.3.0/bin
patching script interpreter paths in /nix/store/1y7iabf6arzj607krb4i6k7sysprgy4z-radare2-2.3.0
/nix/store/1y7iabf6arzj607krb4i6k7sysprgy4z-radare2-2.3.0/bin/ragg2-cc: interpreter directive changed from "/bin/sh" to "/nix/store/shjmvsnwrlg7rd8m0kzgpygqq4if312z-bash-4.4-p12/bin/sh"
/nix/store/1y7iabf6arzj607krb4i6k7sysprgy4z-radare2-2.3.0/bin/r2pm: interpreter directive changed from "/bin/sh" to "/nix/store/shjmvsnwrlg7rd8m0kzgpygqq4if312z-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/1y7iabf6arzj607krb4i6k7sysprgy4z-radare2-2.3.0...
/nix/store/1y7iabf6arzj607krb4i6k7sysprgy4z-radare2-2.3.0

@dtzWill
Copy link
Member Author

dtzWill commented Feb 19, 2018

Yep, that was the reason for the aarch64 failure! Works now! 👍

@gebner gebner merged commit 9b66275 into NixOS:master Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @gebner