Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.1 release #1949

Closed
wants to merge 1 commit into from
Closed

2.0.1 release #1949

wants to merge 1 commit into from

Conversation

shlevy
Copy link
Member

@shlevy shlevy commented Mar 5, 2018

No description provided.

@shlevy shlevy requested a review from edolstra March 5, 2018 17:48
@shlevy
Copy link
Member Author

shlevy commented Mar 5, 2018

Would be nice to have a release with the recent fixes.

@puffnfresh
Copy link
Contributor

Having a release with your ssh-ng fixes would be awesome for my team.

@edolstra
Copy link
Member

edolstra commented Mar 7, 2018

Please just cherry-pick bug fixes to the 2.0-maintenance branch and don't add release notes for bug fix releases.

@edolstra edolstra closed this Mar 7, 2018
@shlevy shlevy deleted the 2.0.1-release branch March 7, 2018 10:09
@shlevy
Copy link
Member Author

shlevy commented Mar 7, 2018

Hmm I think maintenance branches are likely to put us back in the position of having significant divergence between the latest release and the latest master and make it harder to get out feature releases as well. Can you explain why you prefer the maintenance model over releasing from master?

@edolstra
Copy link
Member

edolstra commented Mar 7, 2018

It would be appropriate to release 2.1 from master, but not 2.0.1. Users should be able to count on patch releases like 2.0.1 not introducing regressions.

@shlevy
Copy link
Member Author

shlevy commented Mar 7, 2018

Do you have any thoughts on how we can avoid divergence under this model? My thought is just that we should just bump to 2.1 (not necessarily released, just in the version file) as soon as we make a change justifying that.

@shlevy
Copy link
Member Author

shlevy commented Mar 7, 2018

@edolstra (and rest of @NixOS/nix-core ) can you join the nix-core ml? I'd like to move this discussion there.

@edolstra
Copy link
Member

edolstra commented Mar 7, 2018

Doing more frequent major releases in no way removes the need for a maintenance branch, especially given the existence of stable NixOS branches, since it would be irresponsible to apply major Nix upgrades in a stable NixOS branch (it should only receive bug fixes).

@puffnfresh
Copy link
Contributor

@shlevy I don't think these ended up cherry-picked into the maintenance branch. Is that right?

@shlevy
Copy link
Member Author

shlevy commented Mar 28, 2018

@puffnfresh Correct, there's an ongoing discussion about Nix release process that I hope to turn into an RFC this week https://groups.google.com/forum/#!topic/nix-core/9L7jZ9W8VGc

@shlevy
Copy link
Member Author

shlevy commented Mar 28, 2018

@puffnfresh NixOS/rfcs#28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants