i3-wk-switch: init at 484f840 #36363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
reviewed
Mar 5, 2018
| pkgName = "i3-wk-switch"; | ||
| in | ||
| python2Packages.buildPythonApplication rec { | ||
| name = "${pkgName}-${version}"; |
There was a problem hiding this comment.
Instead of the hash, please instead use the date of the commit.
There was a problem hiding this comment.
You can remove the name attribute, buildPythonApplication will concat pname and version attributes. As your set is recursive (rec) you can move pkgName into the set and rename it to pname
Synthetica9
force-pushed
the
i3-wk-switch
branch
from
956b764
to
24246f2
Compare
|
@grahamc Bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)