Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xen 4.8: fix gcc7-related build errors #36353

Merged
merged 1 commit into from Mar 5, 2018
Merged

xen 4.8: fix gcc7-related build errors #36353

merged 1 commit into from Mar 5, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Mar 5, 2018

Motivation for this change

didn't build with gcc7. fixed with 2 upstream patches.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

/cc @oxij

@xeji
Copy link
Contributor Author

xeji commented Mar 5, 2018

@oxij vanilla, light and slim build now. Please review.
There are also some some newer XSAs that we should apply before we consider making 4.8 the default.

@xeji xeji mentioned this pull request Mar 5, 2018
Merged
5 tasks
@Mic92
Copy link
Member

Mic92 commented Mar 5, 2018

@GrahamcOfBorg build xen_4_8 xen_4_8-light xen_4_8-slim

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘xen-4.8.2’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/applications/virtualization/xen/generic.nix:226 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘xen-4.8.2’ in /var/lib/gc-of-borg/nix-test-rs-32/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-32/pkgs/applications/virtualization/xen/generic.nix:226 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/qymx5a801s2b5z403gb05xdvysqzi5z8-xen-4.8.2/lib/xen/bin/xendomains: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/qymx5a801s2b5z403gb05xdvysqzi5z8-xen-4.8.2/sbin/xen-bugtool: interpreter directive changed from "/usr/bin/env python" to "/nix/store/7b2z0vfbs9539ga4pxx5gmli47rz5y3n-python-2.7.14/bin/python"
/nix/store/qymx5a801s2b5z403gb05xdvysqzi5z8-xen-4.8.2/sbin/xen-ringwatch: interpreter directive changed from "/usr/bin/env python" to "/nix/store/7b2z0vfbs9539ga4pxx5gmli47rz5y3n-python-2.7.14/bin/python"
/nix/store/qymx5a801s2b5z403gb05xdvysqzi5z8-xen-4.8.2/sbin/xenmon.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/7b2z0vfbs9539ga4pxx5gmli47rz5y3n-python-2.7.14/bin/python"
checking for references to /tmp/nix-build-xen-4.8.2.drv-0 in /nix/store/qymx5a801s2b5z403gb05xdvysqzi5z8-xen-4.8.2...
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
moving /nix/store/qymx5a801s2b5z403gb05xdvysqzi5z8-xen-4.8.2/sbin/* to /nix/store/qymx5a801s2b5z403gb05xdvysqzi5z8-xen-4.8.2/bin

@Mic92 Mic92 merged commit c7a92f3 into NixOS:master Mar 5, 2018
@xeji xeji deleted the xen-4-8 branch March 5, 2018 23:58
@oxij
Copy link
Member

oxij commented Mar 6, 2018 via email

vcunat pushed a commit that referenced this pull request Mar 7, 2018
@Mic92 @vcunat
Merge pull request #36353 from xeji/xen-4-8
77d3830 
xen 4.8: fix gcc7-related build errors

(cherry picked from commit c7a92f3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xeji @Mic92 @GrahamcOfBorg @oxij