behave: 1.2.5 -> 1.2.6 #36359

alunduil · 2018-03-05T23:10:09Z

Motivation for this change

Simple package bump of behave. This also includes bumps of parse-type and parse to preserve
dependencies of behave.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Mic92

Also please change to commit messages to have the same format as the pull request title (that I changed).

Mic92 · 2018-03-05T23:23:51Z

pkgs/development/python-modules/parse-type/default.nix

@@ -6,21 +6,13 @@

 buildPythonPackage rec {
  pname = "parse_type";
-  version = "0.3.4";
+  version = "0.4.2";


Can you make this a separate commit?

Mic92 · 2018-03-05T23:23:58Z

pkgs/development/python-modules/parse/default.nix

@@ -3,22 +3,14 @@
 }:
 buildPythonPackage rec {
  pname = "parse";
-  version = "1.6.6";
+  version = "1.8.2";


Can you make this a separate commit?

alunduil · 2018-03-07T17:04:22Z

I cleaned up those commits and made sure each package was separate. Let me know if there is anything else that needs to be changed.

Mic92 · 2018-03-08T09:23:04Z

@GrahamcOfBorg build python27Packages.parse python36Packages.parse-type python27Packages.pyparser python36Packages.parse python36Packages.pyparser python27Packages.behave papis python27Packages.parse-type

GrahamcOfBorg · 2018-03-08T09:23:28Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘python3.6-construct-2.8.16’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/development/python-modules/construct/default.nix:22 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-03-08T09:23:54Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

......Collecting traceback2; python_version < "3.0" (from behave==1.2.6)
  Could not find a version that satisfies the requirement traceback2; python_version < "3.0" (from behave==1.2.6) (from versions: )
No matching distribution found for traceback2; python_version < "3.0" (from behave==1.2.6)
...builder for ‘/nix/store/w2avpply2xcnp9vnl3jab2cxidpvqbp1-behave-1.2.6.drv’ failed with exit code 1
.............. [ 71%]
.....................                                                    [ 82%]
tests/test_parse_util.py .................................               [100%]

========================== 192 passed in 1.93 seconds ==========================
error: build of ‘/nix/store/s0zy03sjw77rvi4yhlfv18xxbzalklkx-papis-0.5.3.drv’, ‘/nix/store/w2avpply2xcnp9vnl3jab2cxidpvqbp1-behave-1.2.6.drv’ failed

GrahamcOfBorg · 2018-03-08T09:24:02Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

tests/test_cardinality_field.py ..........................               [ 43%]
builder for '/nix/store/2fzc6pdvbgcbjrblrqd9aklh023rvgif-behave-1.2.6.drv' failed with exit code 1
tests/test_cfparse.py .........                                          [ 47%]
tests/test_parse_decorator.py .....                                      [ 50%]
tests/test_parse_type_parse.py ......................................... [ 71%]
.....................                                                    [ 82%]
tests/test_parse_util.py .................................               [100%]

========================== 192 passed in 2.59 seconds ==========================
�[31;1merror:�[0m build of '/nix/store/2fzc6pdvbgcbjrblrqd9aklh023rvgif-behave-1.2.6.drv', '/nix/store/vxl6yq830jxwxv658s00fgiz1p0w8mnn-papis-0.5.3.drv' failed

Mic92 · 2018-03-08T09:36:43Z

Looks like traceback2 is missing for python2 or so?

alunduil · 2018-03-08T16:35:56Z

Since behave is designed to be a standalone executable, I've disabled py27. This should resolve the build issues that came up. Let me know if there is anything else.

Mic92 · 2018-03-08T22:51:30Z

pkgs/development/python-modules/behave/default.nix

  name = "${pname}-${version}";

-  disabled = pythonAtLeast "3.6";
+  disabled = isPy27;


So this is not supposed to be executed with the python version one wants to run the tests with? https://github.com/behave/behave

You are correct and I'll add python27 back in. Thanks for pointing out a bad solution.

On a slightly tangential note, how much longer will python27 be the default python installation and available on NixOS?

alunduil · 2018-03-09T01:58:54Z

I've fixed the unacceptable build error and have verified that python27 does build correctly now.

Mic92 · 2018-03-09T07:38:08Z

@alunduil regarding python3 #18185

Mic92 · 2018-03-09T07:38:36Z

@GrahamcOfBorg build python27Packages.parse python36Packages.parse-type python27Packages.pyparser python36Packages.parse python36Packages.pyparser python27Packages.behave papis python27Packages.parse-type

GrahamcOfBorg · 2018-03-09T07:39:04Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘python3.6-construct-2.8.16’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/python-modules/construct/default.nix:22 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-03-09T07:41:03Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

test_cpu_info_match_parser (tests.test_regex.TestRegexParser)
Test parsing /proc/cpuinfo without kwargs ... ok
test_normal (tests.test_format.TestFormatParser) ... ok

----------------------------------------------------------------------
Ran 17 tests in 0.006s

OK
cannot build derivation ‘/nix/store/s0zy03sjw77rvi4yhlfv18xxbzalklkx-papis-0.5.3.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/s0zy03sjw77rvi4yhlfv18xxbzalklkx-papis-0.5.3.drv’ failed

Mic92 · 2018-03-09T07:46:05Z

Was this bibtexparser broken before?

$ nix-shell -p papis
...
creating build/bdist.linux-x86_64
creating build/bdist.linux-x86_64/wheel
creating build/bdist.linux-x86_64/wheel/bibtexparser
copying build/lib/bibtexparser/bwriter.py -> build/bdist.linux-x86_64/wheel/bibtexparser
copying build/lib/bibtexparser/bparser.py -> build/bdist.linux-x86_64/wheel/bibtexparser
copying build/lib/bibtexparser/bibdatabase.py -> build/bdist.linux-x86_64/wheel/bibtexparser
copying build/lib/bibtexparser/__init__.py -> build/bdist.linux-x86_64/wheel/bibtexparser
copying build/lib/bibtexparser/latexenc.py -> build/bdist.linux-x86_64/wheel/bibtexparser
copying build/lib/bibtexparser/customization.py -> build/bdist.linux-x86_64/wheel/bibtexparser
copying build/lib/bibtexparser/bibtexexpression.py -> build/bdist.linux-x86_64/wheel/bibtexparser
running install_egg_info
running egg_info
writing bibtexparser.egg-info/PKG-INFO
writing dependency_links to bibtexparser.egg-info/dependency_links.txt
writing requirements to bibtexparser.egg-info/requires.txt
writing top-level names to bibtexparser.egg-info/top_level.txt
reading manifest file 'bibtexparser.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no files found matching '*.md'
writing manifest file 'bibtexparser.egg-info/SOURCES.txt'
Copying bibtexparser.egg-info to build/bdist.linux-x86_64/wheel/bibtexparser-1.0.1-py3.6.egg-info
running install_scripts
creating build/bdist.linux-x86_64/wheel/bibtexparser-1.0.1.dist-info/WHEEL
creating '/build/bibtexparser-1.0.1/dist/bibtexparser-1.0.1-py3-none-any.whl' and adding '.' to it
adding 'bibtexparser/__init__.py'
adding 'bibtexparser/bibdatabase.py'
adding 'bibtexparser/bibtexexpression.py'
adding 'bibtexparser/bparser.py'
adding 'bibtexparser/bwriter.py'
adding 'bibtexparser/customization.py'
adding 'bibtexparser/latexenc.py'
adding 'bibtexparser-1.0.1.dist-info/DESCRIPTION.rst'
adding 'bibtexparser-1.0.1.dist-info/metadata.json'
adding 'bibtexparser-1.0.1.dist-info/top_level.txt'
adding 'bibtexparser-1.0.1.dist-info/WHEEL'
adding 'bibtexparser-1.0.1.dist-info/METADATA'
adding 'bibtexparser-1.0.1.dist-info/RECORD'
installing
/build/bibtexparser-1.0.1/dist /build/bibtexparser-1.0.1
Processing ./bibtexparser-1.0.1-py3-none-any.whl
Collecting pyparsing (from bibtexparser==1.0.1)
  Could not find a version that satisfies the requirement pyparsing (from bibtexparser==1.0.1) (from versions: )
No matching distribution found for pyparsing (from bibtexparser==1.0.1)
builder for '/nix/store/axil5yxwcvapd4nirvnb8bbajp8865lq-python3.6-bibtexparser-1.0.1.drv' failed with exit code 1
cannot build derivation '/nix/store/h0q3lz09kdjyc9mw8l6aj76ypb88m8gc-papis-0.5.3.drv': 1 dependencies couldn't be built
error: build of '/nix/store/h0q3lz09kdjyc9mw8l6aj76ypb88m8gc-papis-0.5.3.drv' failed

Looks like an easy fix given we already have pyparsing though.

GrahamcOfBorg · 2018-03-09T07:46:43Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

  Failing w/o Encoding-Hint in Steps File (case: python2)  ..........

Issue #606 -- Name option with special unicode chars    # issue.features/issue0606.feature
  Use special unicode chars in --name options  ........

85 features passed, 0 failed, 2 skipped
213 scenarios passed, 0 failed, 3 skipped
1079 steps passed, 0 failed, 24 skipped, 0 undefined
Took 2m31.101s
�[31;1merror:�[0m build of '/nix/store/vxl6yq830jxwxv658s00fgiz1p0w8mnn-papis-0.5.3.drv' failed

alunduil · 2018-03-09T18:16:01Z

@Mic92 I don't think the bibtexparser issue was there before. Let me know if you'd like me to take a crack at fixing that in this branch.

Mic92 · 2018-03-09T19:39:30Z

I would be glad, if you could take a look at it @alunduil

alunduil · 2018-03-12T20:21:19Z

@Mic92 I've fixed the bibtexparser build issues (verified with a nix-build -A papis run locally). Let me know if the commit message is acceptable or if it should be changed to something else. Hopefully, the next run will show everything working as expected.

alunduil · 2018-03-29T15:46:14Z

Finally got a moment to resolve the conflicts. Let me know if any of my choices should be different.

Mic92 · 2018-04-04T18:17:30Z

Thanks!

alunduil requested a review from FRidh as a code owner March 5, 2018 23:10

GrahamcOfBorg added 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 5, 2018

Mic92 changed the title ~~bump behave to version 1.2.6~~ behave: 1.2.5 -> 1.2.6 Mar 5, 2018

Mic92 reviewed Mar 5, 2018

View reviewed changes

Alex Brandt added 2 commits March 7, 2018 11:02

parse: 1.6.6 -> 1.8.2

e39f948

parse-type: 0.3.4 -> 0.4.2

b8c3a16

GrahamcOfBorg added 8.has: clean-up 8.has: package (new) labels Mar 8, 2018

Mic92 reviewed Mar 8, 2018

View reviewed changes

behave: 1.2.5 -> 1.2.6

df9148c

add missing propagatedBuildInputs to bibtexparser

0f5e8a3

GrahamcOfBorg added 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 and removed 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 12, 2018

Merge branch 'master' into bump-behave-version

6d78bde

Mic92 merged commit 814288c into NixOS:master Apr 4, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

behave: 1.2.5 -> 1.2.6 #36359

behave: 1.2.5 -> 1.2.6 #36359

alunduil commented Mar 5, 2018 •

edited

Mic92 left a comment •

edited

Mic92 Mar 5, 2018

Mic92 Mar 5, 2018

alunduil commented Mar 7, 2018

Mic92 commented Mar 8, 2018

GrahamcOfBorg commented Mar 8, 2018

GrahamcOfBorg commented Mar 8, 2018

GrahamcOfBorg commented Mar 8, 2018

Mic92 commented Mar 8, 2018

alunduil commented Mar 8, 2018

Mic92 Mar 8, 2018

alunduil Mar 9, 2018

alunduil commented Mar 9, 2018

Mic92 commented Mar 9, 2018

Mic92 commented Mar 9, 2018

GrahamcOfBorg commented Mar 9, 2018

GrahamcOfBorg commented Mar 9, 2018

Mic92 commented Mar 9, 2018

GrahamcOfBorg commented Mar 9, 2018

alunduil commented Mar 9, 2018

Mic92 commented Mar 9, 2018

alunduil commented Mar 12, 2018

alunduil commented Mar 29, 2018

Mic92 commented Apr 4, 2018

behave: 1.2.5 -> 1.2.6 #36359

behave: 1.2.5 -> 1.2.6 #36359

Conversation

alunduil commented Mar 5, 2018 • edited

Motivation for this change

Things done

Mic92 left a comment • edited

Choose a reason for hiding this comment

Mic92 Mar 5, 2018

Choose a reason for hiding this comment

Mic92 Mar 5, 2018

Choose a reason for hiding this comment

alunduil commented Mar 7, 2018

Mic92 commented Mar 8, 2018

GrahamcOfBorg commented Mar 8, 2018

GrahamcOfBorg commented Mar 8, 2018

GrahamcOfBorg commented Mar 8, 2018

Mic92 commented Mar 8, 2018

alunduil commented Mar 8, 2018

Mic92 Mar 8, 2018

Choose a reason for hiding this comment

alunduil Mar 9, 2018

Choose a reason for hiding this comment

alunduil commented Mar 9, 2018

Mic92 commented Mar 9, 2018

Mic92 commented Mar 9, 2018

GrahamcOfBorg commented Mar 9, 2018

GrahamcOfBorg commented Mar 9, 2018

Mic92 commented Mar 9, 2018

GrahamcOfBorg commented Mar 9, 2018

alunduil commented Mar 9, 2018

Mic92 commented Mar 9, 2018

alunduil commented Mar 12, 2018

alunduil commented Mar 29, 2018

Mic92 commented Apr 4, 2018

alunduil commented Mar 5, 2018 •

edited

Mic92 left a comment •

edited