Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swift: add include for <functional> (#35689) #35695

Merged
merged 2 commits into from Feb 27, 2018
Merged

swift: add include for <functional> (#35689) #35695

merged 2 commits into from Feb 27, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 27, 2018 •
edited

Hopefully fix build, not sure yet as this takes a long time to build :).

Fixes #35689 .

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘swift-4.0.3’ in /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/development/compilers/swift/default.nix:303 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘swift-4.0.3’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/development/compilers/swift/default.nix:303 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@dtzWill
Copy link
Member Author

dtzWill commented Feb 27, 2018

Fixing ar symlink while visiting this. Build is fixed with first commit, but can't install with nix-env due to second problem. See #34893 (comment) .

@dtzWill dtzWill merged commit 5069ad2 into NixOS:master Feb 27, 2018
@dtzWill dtzWill deleted the fix/swift-gcc7 branch February 27, 2018 03:03
@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

Compile Swift Module 'BuildTests' (3 sources)
Compile Swift Module 'BasicTests' (36 sources)
Compile Swift Module 'BasicPerformanceTests' (6 sources)
Compile Swift Module 'SwiftPMPackageTests' (1 sources)
Linking /tmp/nix-build-swift-4.0.3.drv-0/build/buildbot_linux/swiftpm-linux-x86_64/x86_64-unknown-linux/release/SwiftPMPackageTests.xctest
--- Installing swift ---
+ env DESTDIR=/tmp/nix-build-swift-4.0.3.drv-0/install/ /nix/store/9bhialxbn35a1vlgjbvn6nwjgs54cl19-cmake-3.10.2/bin/cmake --build /tmp/nix-build-swift-4.0.3.drv-0/build/buildbot_linux/swift-linux-x86_64 -- install
[1/53] Linking CXX shared library lib/libsourcekitdInProc.so
building of ‘/nix/store/g9aq2lm6hpmnvf94r6r2bvl2w9mlr7bb-swift-4.0.3.drv’ timed out after 3600 seconds
error: build of ‘/nix/store/g9aq2lm6hpmnvf94r6r2bvl2w9mlr7bb-swift-4.0.3.drv’ failed

@dtzWill
Copy link
Member Author

dtzWill commented Feb 27, 2018

go go gadget hydra: https://hydra.nixos.org/build/70215282/nixlog/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nix-build -A swift BUILD FAILS
2 participants
@dtzWill @GrahamcOfBorg