Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.Socket: 2.020 -> 2.027 #36379

Merged
merged 1 commit into from Mar 8, 2018
Merged

perlPackages.Socket: 2.020 -> 2.027 #36379

merged 1 commit into from Mar 8, 2018

Conversation

limeytexan
Copy link
Contributor

Motivation for this change

Found that the Socket module was failing the t/getaddrinfo.t test for much the same reasons it had been failing the t/getnameinfo.t test in a sandbox, so similarly disabled/deleted it in the same way. As I was preparing the PR I also discovered #35693 which highlighted that the Socket module could also stand to be updated to a more recent version, so did that as well while I was at it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@limeytexan
perlPackages.Socket: 2.020 -> 2.027
467c03d 
Also disable t/getaddrinfo.t test which requires network access.
@limeytexan limeytexan mentioned this pull request Mar 8, 2018
Merged
8 tasks
@Mic92
Copy link
Member

Mic92 commented Mar 8, 2018

@GrahamcOfBorg build perlPackages.Socket

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/qpvdzq1q7ciwxkc46a30jc3av6fghm6j-perl-Socket-2.027/lib 
patching script interpreter paths in /nix/store/qpvdzq1q7ciwxkc46a30jc3av6fghm6j-perl-Socket-2.027
checking for references to /tmp/nix-build-perl-Socket-2.027.drv-0 in /nix/store/qpvdzq1q7ciwxkc46a30jc3av6fghm6j-perl-Socket-2.027...
shrinking RPATHs of ELF executables and libraries in /nix/store/x3nl9jairfvgs2v4gjm00qkycdjjjw7p-perl-Socket-2.027-devdoc
gzipping man pages under /nix/store/x3nl9jairfvgs2v4gjm00qkycdjjjw7p-perl-Socket-2.027-devdoc/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/x3nl9jairfvgs2v4gjm00qkycdjjjw7p-perl-Socket-2.027-devdoc
checking for references to /tmp/nix-build-perl-Socket-2.027.drv-0 in /nix/store/x3nl9jairfvgs2v4gjm00qkycdjjjw7p-perl-Socket-2.027-devdoc...
/nix/store/qpvdzq1q7ciwxkc46a30jc3av6fghm6j-perl-Socket-2.027

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/far51fwair6bsx64v25kl43xmivqy8qn-perl-Socket-2.027/lib
patching script interpreter paths in /nix/store/far51fwair6bsx64v25kl43xmivqy8qn-perl-Socket-2.027
checking for references to /build in /nix/store/far51fwair6bsx64v25kl43xmivqy8qn-perl-Socket-2.027...
shrinking RPATHs of ELF executables and libraries in /nix/store/421xiw6yj6psxnlcdbf71dg5kpmgplsm-perl-Socket-2.027-devdoc
gzipping man pages under /nix/store/421xiw6yj6psxnlcdbf71dg5kpmgplsm-perl-Socket-2.027-devdoc/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/421xiw6yj6psxnlcdbf71dg5kpmgplsm-perl-Socket-2.027-devdoc
checking for references to /build in /nix/store/421xiw6yj6psxnlcdbf71dg5kpmgplsm-perl-Socket-2.027-devdoc...
/nix/store/far51fwair6bsx64v25kl43xmivqy8qn-perl-Socket-2.027

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

post-installation fixup
Moving /nix/store/8clm3pmmjp8v48dcpj3h9xcwlyf38n4p-perl-Socket-2.027/share/man/man3 to /nix/store/bs8nxmsnab29yp30d47aan29d62nds5l-perl-Socket-2.027-devdoc/share/man/man3
Removing empty /nix/store/8clm3pmmjp8v48dcpj3h9xcwlyf38n4p-perl-Socket-2.027/share/man/ and (possibly) its parents
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/8clm3pmmjp8v48dcpj3h9xcwlyf38n4p-perl-Socket-2.027/lib
patching script interpreter paths in /nix/store/8clm3pmmjp8v48dcpj3h9xcwlyf38n4p-perl-Socket-2.027
gzipping man pages under /nix/store/bs8nxmsnab29yp30d47aan29d62nds5l-perl-Socket-2.027-devdoc/share/man/
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/bs8nxmsnab29yp30d47aan29d62nds5l-perl-Socket-2.027-devdoc
/nix/store/8clm3pmmjp8v48dcpj3h9xcwlyf38n4p-perl-Socket-2.027

@Mic92
Copy link
Member

Mic92 commented Mar 8, 2018

thanks!

@Mic92 Mic92 merged commit cdd0a24 into NixOS:master Mar 8, 2018
@limeytexan limeytexan deleted the perlPackages-Socket branch March 13, 2018 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@limeytexan @Mic92 @GrahamcOfBorg