kernel-headers: remove deprecated and broken asm symlink fixups #36366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, though you could have a link to the discussion in #36303 on the commit message. BTW, staging has quite a bit of unmerged stuff so might not want to merge this just yet. |
dtzWill
force-pushed
the
fix/kernel-header-asm-symlinks-remove
branch
from
974ff77
to
3a40b33
Compare
|
Good call, updated the commit. Happy to wait re:merging to staging, but not sure how to know when it's in a better condition. Should I just ping this in a few days? :) cc NixOS/rfcs#26 re:staging workflow . (this is low-priority but will cause lots of rebuilds, while also being rather low risk in terms of "let's see if anything breaks") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #36303.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)