-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] OpenSSL RSA Bindings #5777
Conversation
|
||
pkey.public_key.public?.should be_true | ||
end | ||
it "can export to PEM format" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typical style is to treat it
blocks like def
methods and leave a line between each.
Why close this? @CImrie |
Hey @straight-shoota - At the moment I've pulled out a shard instead so that issues can be ironed out much quicker (independently from crystal stdlib updates) with the intention of it being merged in later as a PR. Does that seem sensible? |
@CImrie something as critical as SSL/TLS security should reside in the stdlib |
but this isn't SSL/TLS. Eventually I'm happy to merge this though because it'll make pulling out the |
Sure. Just wanted to know what's up. @RX14 I'm not sure if it makes sense to merge if it's still work in progress. Could be added later in a new PR either to stdlib or when OpenSSL is extracted to a shard. |
For now, removing |
100% agree. I meant that this contribution is maybe not ready yet. At least that's how I understood @CImrie's statement. |
Ah I see what you mean now. No, I wasn't proposing to merge this PR, I was proposing to merge a future PR once this happens:
|
@CImrie what ever happened to this external shard PR ? :) |
Hi @bararchy, I did complete the bindings for what I needed (verifying RSA-signed JWT tokens) but packaged it up in an external shard - https://github.com/randomstate/openssl_ext Is that of any use to you? |
@CImrie that's cool to know, I hope we see you in crystal land again soon, I'll go over the project , thanks for your time |
@bararchy If you are using it for JWT, you can take a look at https://github.com/randomstate/jwt . You can use that library for verification/validation of the tokens or as inspiration if you need anything more bespoke. Believe me, I'm trying to find any way I can to start building projects in crystal again 😅 |
Adds RSA bindings to OpenSSL as mentioned in #3941
One slight nuance - it can't export to PEM format using a passphrase as OpenSSL fails without any error when performing this. Otherwise works similarly to the Ruby API but without aliases.