Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sddm: minor refactoring, test both with and without plasma5 #35184

Closed
wants to merge 1 commit into from
Closed

sddm: minor refactoring, test both with and without plasma5 #35184

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 19, 2018

Introduce test for SDDM+Plasma5, currently fails (locally, anyway?).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
sddm: minor refactoring, test both with and without plasma5
61ef66c 
The former currently demonstrates a problem with SDDM + Plasma5,
which would be good to not regress on in the future.
(see NixOS#32577 for discussion, although it may end up being something else)
@dtzWill dtzWill force-pushed the feature/sddm-test-with-and-without-plasma5 branch from d1f5c2c to 61ef66c Compare February 19, 2018 15:49
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

these paths will be fetched (3.34 MiB download, 4.91 MiB unpacked):
  /nix/store/6gkjyzvfvbjf45kn2rmfqp1dabf6xc14-sddm-0.17.0
copying path '/nix/store/6gkjyzvfvbjf45kn2rmfqp1dabf6xc14-sddm-0.17.0' from 'https://cache.nixos.org'...
/nix/store/6gkjyzvfvbjf45kn2rmfqp1dabf6xc14-sddm-0.17.0

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘sddm-0.17.0’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/display-managers/sddm/default.nix:58 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

copying path '/nix/store/mkmznigj3airzmn2kxhp6bwm9fhxa0ls-libinput-1.9.4' from 'https://cache.nixos.org'...
copying path '/nix/store/dly37h6alzsrm6ai02x1bkl3cbr2pqsf-qtbase-5.10.0' from 'https://cache.nixos.org'...
copying path '/nix/store/37k2mfpf39vp435vipndbsjimzprcpk0-qtbase-5.10.0-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/9ml5wxprnq0vhw8wpi9my6y6nqhbg27a-qtdeclarative-5.10.0' from 'https://cache.nixos.org'...
copying path '/nix/store/i6nnv9pj9afswd0g4q9vp9v1cbfxx589-qtsvg-5.10.0' from 'https://cache.nixos.org'...
copying path '/nix/store/mj5gd6az14lyrj7akf62wiy0f64x8yqn-qtsvg-5.10.0-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/mzddbzffm0snbdvaryncdxwhhfkiy6lj-qtxmlpatterns-5.10.0' from 'https://cache.nixos.org'...
copying path '/nix/store/pwdd5zs3b4xj2hvzr3fvaqbap3bjxch5-qtdeclarative-5.10.0-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/57xxk1k73hsy3c0y3j582nsai2gmxxp8-sddm-0.17.0' from 'https://cache.nixos.org'...
/nix/store/57xxk1k73hsy3c0y3j582nsai2gmxxp8-sddm-0.17.0

@dtzWill
Copy link
Member Author

dtzWill commented Feb 19, 2018

@GrahamcOfBorg test sddm

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

@grahamc
Copy link
Member

grahamc commented Feb 19, 2018

♥‿♥

@dtzWill
Copy link
Member Author

dtzWill commented Feb 19, 2018

Ha! Well, $#@%@ :o).

Anyway I think this is actually the wrong direction as it changes the sddm theme which probably breaks OCR or something.

@dtzWill dtzWill closed this Feb 19, 2018
@shazow shazow mentioned this pull request Mar 30, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @grahamc