Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cram: fix tests #35191

Closed
wants to merge 1 commit into from
Closed

pythonPackages.cram: fix tests #35191

wants to merge 1 commit into from

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Feb 19, 2018 •
edited

Motivation for this change

Cram is broken on staging, but not on master. I don't know why and I have no idea how cram works so I can't figure out what that one test failure is about.
On Python 3, there is no test failure.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

/cc @jluttine

@dotlambda
Copy link
Member Author

@GrahamcOfBorg build python2.pkgs.cram

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

+  IOError: [Errno 32] Broken pipe
+  [1]
+  $ md5 examples/fail.t examples/fail.t.err
+  0f598c2b7b8ca5bcb8880e492ff6b452  examples/fail.t
+  7a23dfa85773c77648f619ad0f9df554  examples/fail.t.err
   $ rm patch examples/fail.t.err
ss...
# Ran 11 tests, 3 skipped, 1 failed.
builder for '/nix/store/17bgzqx5hwmy46mjnmjim1ljm0xq1hhv-python2.7-cram-0.7.drv' failed with exit code 1
error: build of '/nix/store/17bgzqx5hwmy46mjnmjim1ljm0xq1hhv-python2.7-cram-0.7.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/7662z3biykaxcp8h9543zaq7hh9hgnbf-python2.7-cram-0.7
strip is /nix/store/qp4g6waq07493xinscfmba5qkl22fspd-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/7662z3biykaxcp8h9543zaq7hh9hgnbf-python2.7-cram-0.7/lib  /nix/store/7662z3biykaxcp8h9543zaq7hh9hgnbf-python2.7-cram-0.7/bin
patching script interpreter paths in /nix/store/7662z3biykaxcp8h9543zaq7hh9hgnbf-python2.7-cram-0.7
checking for references to /build in /nix/store/7662z3biykaxcp8h9543zaq7hh9hgnbf-python2.7-cram-0.7...
wrapping `/nix/store/7662z3biykaxcp8h9543zaq7hh9hgnbf-python2.7-cram-0.7/bin/cram'...
running install tests
..s...ss...
# Ran 11 tests, 3 skipped, 0 failed.
/nix/store/7662z3biykaxcp8h9543zaq7hh9hgnbf-python2.7-cram-0.7

@dotlambda
Copy link
Member Author

@GrahamcOfBorg build python2.pkgs.cram python3.pkgs.cram

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

strip is /nix/store/qp4g6waq07493xinscfmba5qkl22fspd-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/a04af4h2kjnj28c9lggsb4dgs77j361f-python3.6-cram-0.7/lib  /nix/store/a04af4h2kjnj28c9lggsb4dgs77j361f-python3.6-cram-0.7/bin
patching script interpreter paths in /nix/store/a04af4h2kjnj28c9lggsb4dgs77j361f-python3.6-cram-0.7
checking for references to /build in /nix/store/a04af4h2kjnj28c9lggsb4dgs77j361f-python3.6-cram-0.7...
wrapping `/nix/store/a04af4h2kjnj28c9lggsb4dgs77j361f-python3.6-cram-0.7/bin/cram'...
running install tests
..s...ss...
# Ran 11 tests, 3 skipped, 0 failed.
/nix/store/7662z3biykaxcp8h9543zaq7hh9hgnbf-python2.7-cram-0.7
/nix/store/a04af4h2kjnj28c9lggsb4dgs77j361f-python3.6-cram-0.7

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

cannot build derivation ‘/nix/store/dhkydvn44w5i5k9xmmr8xp3jn0fvhkg8-python3-3.6.4.drv’: 12 dependencies couldn't be built
cannot build derivation ‘/nix/store/a20491zrwkkpqvvpgxry5h84givgb2ak-hook.drv’: 4 dependencies couldn't be built
cannot build derivation ‘/nix/store/w7jmiij7vxr4byq95v4h4f684lc8k99k-hook.drv’: 4 dependencies couldn't be built
cannot build derivation ‘/nix/store/ykl4v3dc627lkvg30fi4lghnw1891xqs-python2.7-bootstrapped-pip-9.0.1.drv’: 5 dependencies couldn't be built
cannot build derivation ‘/nix/store/nxqn06wv9ijrjm7ksgawj8hcrzq9zj0q-python3.6-bootstrapped-pip-9.0.1.drv’: 5 dependencies couldn't be built
cannot build derivation ‘/nix/store/d7kpi4glh11v22pxf0iixcx2m2cnwcli-python2.7-setuptools-38.4.0.drv’: 5 dependencies couldn't be built
cannot build derivation ‘/nix/store/ypbdhzzqz5b8b9higzjqqc7lkfxxw7vj-python3.6-setuptools-38.4.0.drv’: 5 dependencies couldn't be built
cannot build derivation ‘/nix/store/8zv577449is449glw688hxhyl4lxwapp-python2.7-cram-0.7.drv’: 8 dependencies couldn't be built
cannot build derivation ‘/nix/store/fkjgd9hlv9an5d6pwzxdaa40mwaxqy5h-python3.6-cram-0.7.drv’: 8 dependencies couldn't be built
error: build of ‘/nix/store/8zv577449is449glw688hxhyl4lxwapp-python2.7-cram-0.7.drv’, ‘/nix/store/fkjgd9hlv9an5d6pwzxdaa40mwaxqy5h-python3.6-cram-0.7.drv’ failed

@dotlambda
Copy link
Member Author

@GrahamcOfBorg build python2.pkgs.cram python3.pkgs.cram

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

checking for references to /tmp/nix-build-python3.6-cram-0.7.drv-0 in /nix/store/82dbs7v34vr2wf8akmnn8rmh2b2xaa88-python3.6-cram-0.7...
running install tests
wrapping `/nix/store/82dbs7v34vr2wf8akmnn8rmh2b2xaa88-python3.6-cram-0.7/bin/cram'...
running install tests
...s..s...ss...ss..
# Ran 11 tests, 3 skipped, 0 failed.
...
# Ran 11 tests, 3 skipped, 0 failed.
/nix/store/xynd8v7p45nhr0gkd44hvsffbd81dai3-python2.7-cram-0.7
/nix/store/82dbs7v34vr2wf8akmnn8rmh2b2xaa88-python3.6-cram-0.7

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

checking for references to /build in /nix/store/hihq6w15x4d9p7j9sf050bchgg0rb491-python3.6-cram-0.7...
wrapping `/nix/store/hihq6w15x4d9p7j9sf050bchgg0rb491-python3.6-cram-0.7/bin/cram'...
running install tests
running install tests
..s...ss...
# Ran 11 tests, 3 skipped, 0 failed.
..s...ss...
# Ran 11 tests, 3 skipped, 0 failed.
/nix/store/lzx63bw6r56503w3ry7ql6g06v61i6sl-python2.7-cram-0.7
/nix/store/hihq6w15x4d9p7j9sf050bchgg0rb491-python3.6-cram-0.7

@dotlambda dotlambda changed the title [WIP] pythonPackages.cram: fix tests pythonPackages.cram: fix tests Feb 20, 2018
@FRidh
Copy link
Member

FRidh commented Feb 20, 2018

@dotlambda are you on #nixos channel sometimes and if so, what's your id?

@dotlambda
Copy link
Member Author

Sometimes, yes. It's dotlambda.

jluttine
jluttine reviewed Feb 20, 2018
View reviewed changes
pkgs/development/python-modules/cram/default.nix Outdated
@@ -1,32 +1,24 @@
{stdenv, lib, buildPythonPackage, fetchPypi, coverage, bash, which, writeText}:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps remove coverage here too so it's a bit cleaner?

@dotlambda
Copy link
Member Author

Included in #35198.

@dotlambda dotlambda closed this Feb 20, 2018
@dotlambda dotlambda deleted the cram branch February 20, 2018 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jluttine jluttine jluttine left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @GrahamcOfBorg @FRidh @jluttine