Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ppl: fix build #35192

Merged
merged 1 commit into from Feb 20, 2018
Merged

ppl: fix build #35192

merged 1 commit into from Feb 20, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Feb 19, 2018

Motivation for this change

ppl has been broken on darwin since 19d8850 (according to git bisect); it may thus affect other clang-based stdenvs:

In file included from Polyhedron_widenings.cc:28:
In file included from ./Rational_Box.hh:28:
In file included from ./Box_defs.hh:2286:
In file included from ./Box_templates.hh:38:
In file included from ./BD_Shape_defs.hh:2371:
In file included from ./BD_Shape_inlines.hh:31:
In file included from ./Octagonal_Shape_defs.hh:36:
In file included from ./OR_Matrix_defs.hh:607:
./OR_Matrix_inlines.hh:100:8: error: missing 'typename' prior to dependent type template name 'OR_Matrix<T>::Pseudo_Row'
inline OR_Matrix<T>::Pseudo_Row<U>&
       ^
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/154kl2vzzwip4g9a6p8q9jk66c2pmpfi-ppl-1.2/bin/ppl-config
shrinking /nix/store/154kl2vzzwip4g9a6p8q9jk66c2pmpfi-ppl-1.2/bin/ppl_lcdd
shrinking /nix/store/154kl2vzzwip4g9a6p8q9jk66c2pmpfi-ppl-1.2/lib/libppl.so.14.0.0
shrinking /nix/store/154kl2vzzwip4g9a6p8q9jk66c2pmpfi-ppl-1.2/lib/libppl_c.so.4.0.0
gzipping man pages under /nix/store/154kl2vzzwip4g9a6p8q9jk66c2pmpfi-ppl-1.2/share/man/
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/154kl2vzzwip4g9a6p8q9jk66c2pmpfi-ppl-1.2/lib  /nix/store/154kl2vzzwip4g9a6p8q9jk66c2pmpfi-ppl-1.2/bin 
patching script interpreter paths in /nix/store/154kl2vzzwip4g9a6p8q9jk66c2pmpfi-ppl-1.2
checking for references to /tmp/nix-build-ppl-1.2.drv-0 in /nix/store/154kl2vzzwip4g9a6p8q9jk66c2pmpfi-ppl-1.2...
/nix/store/154kl2vzzwip4g9a6p8q9jk66c2pmpfi-ppl-1.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/376r3r9zsbrn2f86i3jv83bq0m5sbya4-ppl-1.2/bin/ppl_lcdd
shrinking /nix/store/376r3r9zsbrn2f86i3jv83bq0m5sbya4-ppl-1.2/bin/ppl-config
shrinking /nix/store/376r3r9zsbrn2f86i3jv83bq0m5sbya4-ppl-1.2/lib/libppl_c.so.4.0.0
shrinking /nix/store/376r3r9zsbrn2f86i3jv83bq0m5sbya4-ppl-1.2/lib/libppl.so.14.0.0
gzipping man pages under /nix/store/376r3r9zsbrn2f86i3jv83bq0m5sbya4-ppl-1.2/share/man/
strip is /nix/store/skd6ix5ipkyhxzq7naylj4digawakl4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/376r3r9zsbrn2f86i3jv83bq0m5sbya4-ppl-1.2/lib  /nix/store/376r3r9zsbrn2f86i3jv83bq0m5sbya4-ppl-1.2/bin
patching script interpreter paths in /nix/store/376r3r9zsbrn2f86i3jv83bq0m5sbya4-ppl-1.2
checking for references to /build in /nix/store/376r3r9zsbrn2f86i3jv83bq0m5sbya4-ppl-1.2...
/nix/store/376r3r9zsbrn2f86i3jv83bq0m5sbya4-ppl-1.2

@Mic92 Mic92 merged commit eda72ad into NixOS:master Feb 20, 2018
@vbgl vbgl deleted the ppl-typename branch May 22, 2019 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.kind: bug 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @GrahamcOfBorg @Mic92