Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debBuild: install all packages at once to avoid dependency management #35177

Merged
merged 1 commit into from Feb 20, 2018
Merged

debBuild: install all packages at once to avoid dependency management #35177

merged 1 commit into from Feb 20, 2018

Conversation

abbradar
Copy link
Member

Motivation for this change

Previously if debbuild generated two packages (say nix-debugsym and nix) and the first one had a dependency on a second, it could be tried to be installed first and fail.

Needed for NixOS/nix#1141

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@abbradar abbradar mentioned this pull request Feb 19, 2018
Closed
@Mic92 Mic92 merged commit c7aa4fd into NixOS:master Feb 20, 2018
@Mic92
Copy link
Member

Mic92 commented Feb 20, 2018

welcome back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.kind: bug 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abbradar @Mic92 @GrahamcOfBorg