Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cups service: fix printing for chrome #35190

Closed
wants to merge 1 commit into from
Closed

cups service: fix printing for chrome #35190

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 19, 2018

Motivation for this change

Closes #34963
Also I'm not sure about original Listen /var/run/cups/cups.sock. Who creates /var/run/cups folder?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@abbradar
Copy link
Member

That's strange; at least on Ubuntu socket is placed there too. Not sure about "who creates it" part. Either way, why would our Chromium use /var/run/cups.sock instead?

@ghost
Copy link
Author

ghost commented Feb 23, 2018 •
edited by ghost

@abbradar

That's strange; at least on Ubuntu socket is placed there too

Right.

Not sure about "who creates it" part

I mean /var/run/cups folder. I've once got a situation where CUPS wouldn't create /var/run/cups/cups.sock socket because /var/run/cups folder was not exist.

Either way, why would our Chromium use /var/run/cups.sock instead?

Not only Chromium. I've straced Firefox, and by some reason it only looks for /var/run/cups.sock too: #34963 Maybe something is broken only on my system?

@abbradar
Copy link
Member

Yep, found it -- we indeed have a broken configuration in CUPS:

#define CUPS_STATEDIR "/run"
#define CUPS_DEFAULT_DOMAINSOCKET "/run/cups.sock"

I'd say rather than fixing NixOS we should fix this in CUPS to give it a separate directory in /run. It can be created using systemd's RuntimeDirectories.

@ghost
Copy link
Author

ghost commented Feb 23, 2018

@abbradar Cool, thanks for finding the root of issue!

@abbradar abbradar mentioned this pull request Feb 23, 2018
Merged
8 tasks
@ghost ghost closed this Feb 23, 2018
@ghost ghost deleted the cups branch February 23, 2018 12:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abbradar @GrahamcOfBorg